Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gif_cond_exp has incorrect model information #3218

Open
jessica-mitchell opened this issue Jun 7, 2024 · 0 comments
Open

gif_cond_exp has incorrect model information #3218

jessica-mitchell opened this issue Jun 7, 2024 · 0 comments
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation Models

Comments

@jessica-mitchell
Copy link
Contributor

It appears that the documentation in the conductance-based gif model is copied from the gif_psc_exp model.
The gif_cond model should presumably have different equations from the psc model.

The gif models should be reviewed to ensure that the documentation is correct
@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 7, 2024
@jessica-mitchell jessica-mitchell added this to To do in Documentation via automation Jun 7, 2024
@jessica-mitchell jessica-mitchell added this to To do in Models via automation Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
To do
Models
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jessica-mitchell