Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or hide password in Data Source UI #18007

Open
mskalecki opened this issue Nov 13, 2024 · 1 comment · May be fixed by #18026
Open

Remove or hide password in Data Source UI #18007

mskalecki opened this issue Nov 13, 2024 · 1 comment · May be fixed by #18026
Assignees
@mskalecki
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@mskalecki
Copy link

NetBox version

v4.1.6

Feature type

Change to existing functionality

Triage priority

I volunteer to perform this work (if approved)

Proposed functionality

Remove or hide the plain text password that is currently displayed in the Backend section of the Data Source view.

Use case

I'm using fine-grained personal access tokens to connect to private GitHub repositories as Data Sources. While these access tokens have very minimal permissions, I don't think they should be displayed in plain text any time I navigate to the Data Source in the UI.

At a minimum, the password / PAT should be hidden (requiring a click to expose the plain text), but I can't see any good reason to show them at all and would just remove it from the view entirely.

Database changes

None

External dependencies

None
@mskalecki mskalecki added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Nov 13, 2024
@mskalecki
Copy link
Author

I took a look at the relevant html template, and I see that the sensitive_parameters (including password) are hidden from users who don't have permissions to change the fields, but really this should be hidden from everyone, especially in the non-edit view.

@bctiemann bctiemann added the complexity: low Requires minimal effort to implement label Nov 15, 2024 — with Linear
@bctiemann bctiemann removed the status: needs triage This issue is awaiting triage by a maintainer label Nov 15, 2024
@bctiemann bctiemann added the status: accepted This issue has been accepted for implementation label Nov 15, 2024
@mskalecki mskalecki linked a pull request Nov 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mskalecki mskalecki

Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide sensitive_parameters from datasource view even for high privil… mskalecki/netbox
2 participants
@bctiemann @mskalecki