Closes #19523: Add counter‑cached counts & filters for DeviceType, ModuleType, and RackType #20718
Conversation
pheus
force-pushed
the
19523-add-instance-filter-for-devicetype-and-moduletype-countcachefield
branch
from
cb711da to
50a63be
Compare
|
Thanks for the thoughtful review and the migration tip - much appreciated! I’ve added a data migration to prefill |
|
I just noticed an earlier FR comment asking to extend this to RackType as well - sorry I missed that. I’m happy to apply the same approach to |
|
@pheus I think it makes sense to fold that in here as well, since it's a continuation of the same pattern. Thanks! |
pheus
force-pushed
the
19523-add-instance-filter-for-devicetype-and-moduletype-countcachefield
branch
from
50a63be to
5eecaa0
Compare
| from .devices import Device, Module | ||
| from .devices import Device | ||
| from .modules import Module |
There was a problem hiding this comment.
Note: Unrelated import fix. Happy to drop this if you'd prefer to keep the PR focused.
| def get_available_units(self, u_height=1, rack_face=None, exclude=None, ignore_excluded_devices=False): | ||
| def get_available_units(self, u_height=1.0, rack_face=None, exclude=None, ignore_excluded_devices=False): |
There was a problem hiding this comment.
Note: Unrelated cleanup. Happy to drop this if you'd prefer to keep the PR focused.
pheus
changed the title
Introduces `device_count`, `module_count` and `rack_count` filters to enable queries based on the existence and count of the associated device, module or rack instances. Updates forms, filtersets, and GraphQL schema to support these filters, along with tests for validation. Fixes netbox-community#19523
pheus
force-pushed
the
19523-add-instance-filter-for-devicetype-and-moduletype-countcachefield
branch
from
5eecaa0 to
d14e741
Compare
|
Thanks! I’ve applied the same approach to |
2 participants
Fixes: #19523
Summary
Extend usage-count filtering via counter caches to cover DeviceType, ModuleType, and RackType.
Implementation
device_counton DeviceTypemodule_counton ModuleTyperack_counton RackTypedevice_count__gte=10,module_count=0,{rack_count: {gt: 2}).Database Changes
Adds integer fields on the three models listed above.