Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support auth_required=True on PluginMenuItem #204

Closed
bctiemann opened this issue Jan 29, 2025 · 0 comments · Fixed by #205
Closed

Support auth_required=True on PluginMenuItem #204

bctiemann opened this issue Jan 29, 2025 · 0 comments · Fixed by #205
Assignees
@bctiemann
Labels
status: accepted type: bug A confirmed report of unexpected behavior in the application
Milestone
v0.6

Comments

@bctiemann
Copy link
Contributor

Plugin Version

0.5.2

Proposed functionality

Once support for it is present in NetBox (v4.2.3), this plugin should add auth_required=True to its PluginMenuItems.

Use case

This will prevent those menu items from showing up in the nav menu if LOGIN_REQUIRED = False.

External dependencies

No response
@bctiemann bctiemann added the type: feature A new feature or functionality label Jan 29, 2025
@bctiemann bctiemann mentioned this issue Jan 29, 2025
Merged
@bctiemann bctiemann added type: bug A confirmed report of unexpected behavior in the application and removed type: feature A new feature or functionality labels Jan 30, 2025
jeremystretch added a commit that referenced this issue Feb 5, 2025
@bctiemann @jeremystretch
Closes: #204 - Add auth_required to PluginMenuItems (#205)
f2995d1 
* Set auth_required=True on PluginMenuItems
* Set min_version to 4.2.3

---------

Co-authored-by: Jeremy Stretch <[email protected]>
@jeremystretch jeremystretch added this to the v0.6 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bctiemann bctiemann

Labels
status: accepted type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

Closes: #204 - Add auth_required to PluginMenuItems netboxlabs/netbox-branching
2 participants
@bctiemann @jeremystretch