Skip to content

Commit 4745218

Browse files
TbaileTbaile
committed
fix!: propagate types to downstream projects
BREAKING_CHANGE: Typing is now checked while building applications that depends on this library, expect typescript builds to fail.
1 parent 9c84df8 commit 4745218

File tree

7 files changed

+51
-61
lines changed

7 files changed

+51
-61
lines changed

‎src/components/NeExpandable.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'
88
import { faChevronDown, faChevronUp } from '@fortawesome/free-solid-svg-icons'
99
import { onMounted, ref, watch } from 'vue'
10-
import { NeButton } from '@/main'
10+
import NeButton from './NeButton.vue'
1111

1212
const props = defineProps({
1313
label: {

‎src/components/NeFileInput.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import { computed } from 'vue'
88
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'
99
import { faFileArrowUp } from '@fortawesome/free-solid-svg-icons'
10-
import NeProgressBar from '@/components/NeProgressBar.vue'
10+
import NeProgressBar from './NeProgressBar.vue'
1111

1212
interface FileInputProps {
1313
modelValue?: File | File[] | null
@@ -107,7 +107,7 @@ const dragOverHandler = (event: Event) => {
107107
{{ dropZoneText }}
108108
</p>
109109
</div>
110-
<input class="hidden" type="file" :accept="accept" />
110+
<input :accept="accept" class="hidden" type="file" />
111111
<!-- progress bar -->
112112
<NeProgressBar
113113
v-if="showProgress"

‎src/components/NePaginator.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { range } from 'lodash-es'
99
import { faChevronLeft as fasChevronLeft } from '@fortawesome/free-solid-svg-icons'
1010
import { faChevronRight as fasChevronRight } from '@fortawesome/free-solid-svg-icons'
1111
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'
12-
import { NeListbox } from '@/main'
12+
import NeListbox from './NeListbox.vue'
1313

1414
export type NePaginatorProps = {
1515
currentPage: number

‎src/components/NeRadioSelection.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { type PropType, type Ref, ref, watch } from 'vue'
88
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'
99
import { library } from '@fortawesome/fontawesome-svg-core'
1010
import { faCircleCheck } from '@fortawesome/free-solid-svg-icons'
11-
import NeFormItemLabel from '@/components/NeFormItemLabel.vue'
11+
import NeFormItemLabel from './NeFormItemLabel.vue'
1212

1313
export type RadioCardSize = 'md' | 'lg' | 'xl'
1414

‎src/main.ts

Lines changed: 44 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,48 @@
11
// style export
2-
import '@/main.css'
2+
import './main.css'
33

44
// components export
5-
export { default as NeSkeleton } from '@/components/NeSkeleton.vue'
6-
export { default as NeSpinner } from '@/components/NeSpinner.vue'
7-
export { default as NeExpandable } from '@/components/NeExpandable.vue'
8-
export { default as NeProgressBar } from '@/components/NeProgressBar.vue'
9-
export { default as NeFileInput } from '@/components/NeFileInput.vue'
10-
export { default as NeInlineNotification } from '@/components/NeInlineNotification.vue'
11-
export { default as NeRoundedIcon } from '@/components/NeRoundedIcon.vue'
12-
export { default as NeSideDrawer } from '@/components/NeSideDrawer.vue'
13-
export { default as NeTooltip } from '@/components/NeTooltip.vue'
14-
export { default as NeBadge } from '@/components/NeBadge.vue'
15-
export { default as NeButton } from '@/components/NeButton.vue'
16-
export { default as NeCheckbox } from '@/components/NeCheckbox.vue'
17-
export { default as NeTable } from '@/components/NeTable.vue'
18-
export { default as NeTableHead } from '@/components/NeTableHead.vue'
19-
export { default as NeTableHeadCell } from '@/components/NeTableHeadCell.vue'
20-
export { default as NeTableBody } from '@/components/NeTableBody.vue'
21-
export { default as NeTableRow } from '@/components/NeTableRow.vue'
22-
export { default as NeTableCell } from '@/components/NeTableCell.vue'
23-
export { default as NeCombobox } from '@/components/NeCombobox.vue'
24-
export { default as NeDropdown } from '@/components/NeDropdown.vue'
25-
export { default as NeCard } from '@/components/NeCard.vue'
26-
export { default as NeLink } from '@/components/NeLink.vue'
27-
export { default as NeFormItemLabel } from '@/components/NeFormItemLabel.vue'
28-
export { default as NeRadioSelection } from '@/components/NeRadioSelection.vue'
29-
export { default as NePaginator } from '@/components/NePaginator.vue'
30-
export { default as NeEmptyState } from '@/components/NeEmptyState.vue'
31-
export { default as NeTabs } from '@/components/NeTabs.vue'
32-
export { default as NeTextArea } from '@/components/NeTextArea.vue'
33-
export { default as NeTextInput } from '@/components/NeTextInput.vue'
34-
export { default as NeToggle } from '@/components/NeToggle.vue'
35-
export { default as NeToastNotification } from '@/components/NeToastNotification.vue'
36-
export { default as NeModal } from '@/components/NeModal.vue'
37-
export { default as NeHeading } from '@/components/NeHeading.vue'
38-
export { default as NeListbox } from '@/components/NeListbox.vue'
5+
export { default as NeSkeleton } from './components/NeSkeleton.vue'
6+
export { default as NeSpinner } from './components/NeSpinner.vue'
7+
export { default as NeExpandable } from './components/NeExpandable.vue'
8+
export { default as NeProgressBar } from './components/NeProgressBar.vue'
9+
export { default as NeFileInput } from './components/NeFileInput.vue'
10+
export { default as NeInlineNotification } from './components/NeInlineNotification.vue'
11+
export { default as NeRoundedIcon } from './components/NeRoundedIcon.vue'
12+
export { default as NeSideDrawer } from './components/NeSideDrawer.vue'
13+
export { default as NeTooltip } from './components/NeTooltip.vue'
14+
export { default as NeBadge } from './components/NeBadge.vue'
15+
export { default as NeButton } from './components/NeButton.vue'
16+
export { default as NeCheckbox } from './components/NeCheckbox.vue'
17+
export { default as NeTable } from './components/NeTable.vue'
18+
export { default as NeTableHead } from './components/NeTableHead.vue'
19+
export { default as NeTableHeadCell } from './components/NeTableHeadCell.vue'
20+
export { default as NeTableBody } from './components/NeTableBody.vue'
21+
export { default as NeTableRow } from './components/NeTableRow.vue'
22+
export { default as NeTableCell } from './components/NeTableCell.vue'
23+
export { default as NeCombobox } from './components/NeCombobox.vue'
24+
export { default as NeDropdown } from './components/NeDropdown.vue'
25+
export { default as NeCard } from './components/NeCard.vue'
26+
export { default as NeLink } from './components/NeLink.vue'
27+
export { default as NeFormItemLabel } from './components/NeFormItemLabel.vue'
28+
export { default as NeRadioSelection } from './components/NeRadioSelection.vue'
29+
export { default as NePaginator } from './components/NePaginator.vue'
30+
export { default as NeEmptyState } from './components/NeEmptyState.vue'
31+
export { default as NeTabs } from './components/NeTabs.vue'
32+
export { default as NeTextArea } from './components/NeTextArea.vue'
33+
export { default as NeTextInput } from './components/NeTextInput.vue'
34+
export { default as NeToggle } from './components/NeToggle.vue'
35+
export { default as NeToastNotification } from './components/NeToastNotification.vue'
36+
export { default as NeModal } from './components/NeModal.vue'
37+
export { default as NeHeading } from './components/NeHeading.vue'
38+
export { default as NeListbox } from './components/NeListbox.vue'
3939

4040
// types export
41-
export type { NeComboboxOption } from '@/components/NeCombobox.vue'
42-
export type { NePaginatorProps } from '@/components/NePaginator.vue'
43-
export type { Tab } from '@/components/NeTabs.vue'
44-
export type { NeNotification } from '@/components/NeToastNotification.vue'
45-
export type { NeListboxOption } from '@/components/NeListbox.vue'
41+
export type { NeComboboxOption } from './components/NeCombobox.vue'
42+
export type { NePaginatorProps } from './components/NePaginator.vue'
43+
export type { Tab } from './components/NeTabs.vue'
44+
export type { NeNotification } from './components/NeToastNotification.vue'
45+
export type { NeListboxOption } from './components/NeListbox.vue'
4646

4747
// library functions export
4848
export {
@@ -52,22 +52,22 @@ export {
5252
byteFormat1024,
5353
byteFormat1000,
5454
kbpsFormat
55-
} from '@/lib/utils'
55+
} from './lib/utils'
5656
export {
5757
formatDateLoc,
5858
formatInTimeZoneLoc,
5959
getDateFnsLocale,
6060
formatDurationLoc,
6161
humanDistanceToNowLoc
62-
} from '@/lib/dateTime'
62+
} from './lib/dateTime'
6363
export {
6464
saveToStorage,
6565
getJsonFromStorage,
6666
getStringFromStorage,
6767
deleteFromStorage,
6868
savePreference,
6969
getPreference
70-
} from '@/lib/storage'
70+
} from './lib/storage'
7171

7272
// composables export
73-
export { useItemPagination } from '@/composables/useItemPagination'
73+
export { useItemPagination } from './composables/useItemPagination'

‎tsconfig.app.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55
"compilerOptions": {
66
"composite": true,
77
"baseUrl": ".",
8-
"outDir": "dist",
9-
"paths": {
10-
"@/*": ["./src/*"]
11-
}
8+
"outDir": "dist"
129
}
1310
}

‎vite.config.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { fileURLToPath, URL } from 'node:url'
2-
31
import { defineConfig } from 'vite'
42
import vue from '@vitejs/plugin-vue'
53
import { resolve } from 'path'
@@ -38,10 +36,5 @@ export default defineConfig({
3836
}
3937
}
4038
},
41-
plugins: [vue()],
42-
resolve: {
43-
alias: {
44-
'@': fileURLToPath(new URL('./src', import.meta.url))
45-
}
46-
}
39+
plugins: [vue()]
4740
})

0 commit comments

Comments
 (0)