Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo stats window does not scroll #63

Closed
GuitarBilly opened this issue Jun 12, 2024 · 2 comments
Closed

repo stats window does not scroll #63

GuitarBilly opened this issue Jun 12, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@GuitarBilly
Copy link

v3.0.0.1.rc1
https://github.com/netinvent/npbackup/releases/tag/v3.0.0-rc1

When running stats on a repo the tiny window does not scroll so it appears nothing happens after you start stats.
This is a minor issue for me since functionality works and it appears as cosmetic.

steps to reproduce:

  1. start npbackup-gui with one repo config
  2. select Operations
  3. select Repo Statistics
  4. choose a Repo (group) and press any of the Apply

screenshot immediately after starting stats:
afbeelding

screenshot after stats finished:
afbeelding

If the many execution step and status/debug messages would be skipped then the one important line could be printed visible for the user, i.e.:

Running stats for repo default
{"total_size":42426270,"total_file_count":749,"snapshots_count":10}

instead of

Running stats for repo default

Getting stats of repo default
{"total_size":42426270,"total_file_count":749,"snapshots_count":10}

Repo statistics command success

Runner took 1.648825 seconds for stats

Finished execution group operations

Runner took 1.649909 seconds for group_runner

Or one can question the size of the Last Messages window vs Debug Message window. Do we really expect so many errors to be displayed to the user? :-)
Anyway there are 1000 solutions so I leave it to you to ponder upon.

@deajan
Copy link
Contributor

deajan commented Jun 15, 2024

So actually I disabled the autoscroll because it slowed down when there were alot of messages.
Also, I don't filter restic output here, so I won't be able to "skim" the text down.
Of course, the suggestion to make the debug message field smaller than the actual output makes sense ^^
I'll update this for RC2.

@deajan deajan added the enhancement New feature or request label Jun 15, 2024
@deajan deajan added this to the 3.0 milestone Jun 15, 2024
@deajan deajan closed this as completed in 453551c Jun 17, 2024
@deajan
Copy link
Contributor

deajan commented Jun 17, 2024

Current git master now scrolls unless we have list or backup operations, which produce way too much output and make autoscrolling slow.
Also resized stdout log and tried to filter out empty lines.

You can try by installing the git master, or wait for a RC2 release which hopefully should happen somewhere in July.
Feel free to re-open the issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants