Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple parent certificates #41

Open
cyrill-k opened this issue May 26, 2023 · 1 comment
Open

Allow multiple parent certificates #41

cyrill-k opened this issue May 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cyrill-k
Copy link
Collaborator

Currently, each certificate is tied to a single parent certificate.
However, this is not always the case, e.g., if a root or intermediate certificate is renewed with the same subject name and public key.
This could be solved by adding the "issuer identity", which is the tuple of (subject name, subject key identifier, signature algorithm), as an additional field to the parent/child table in the database.

@juagargi juagargi added the bug Something isn't working label May 26, 2023
@juagargi
Copy link
Member

Note for self:

Be careful during ingestion time, that the certificates that are ingested are not used as issuers by any existing certificates.
It they are, we recursively find any certificate that is a descendant of any cert in the set. Then finding the unique set of domains that have any of these certificates using the domain_certs table (which will have to have an index on cert_id).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants