Skip to content

Commit 5ffe263

Browse files
committed
Cache::save() with closure is deprecated (BC break)
It was internal usage
1 parent 8804ccb commit 5ffe263

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/Caching/Cache.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ public function save($key, $data, array $dependencies = null)
169169
$key = $this->generateKey($key);
170170

171171
if ($data instanceof \Closure) {
172+
trigger_error(__METHOD__ . '() closure argument is deprecated.', E_USER_WARNING);
172173
$this->storage->lock($key);
173174
try {
174175
$data = $data(...[&$dependencies]);

tests/Caching/Cache.save.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Assert::same($dependencies, $res['dependencies']);
3131
$storage = new testStorage;
3232
$cache = new Cache($storage, 'ns');
3333

34-
$cache->save('key', function () {
34+
@$cache->save('key', function () { // @ deprecated
3535
return 'value';
3636
});
3737

@@ -45,7 +45,7 @@ $storage = new testStorage;
4545
$cache = new Cache($storage, 'ns');
4646
$dependencies = [Cache::TAGS => ['tag']];
4747

48-
$cache->save('key', function () {
48+
@$cache->save('key', function () { // @ deprecated
4949
return 'value';
5050
}, $dependencies);
5151

@@ -59,7 +59,7 @@ $storage = new testStorage;
5959
$cache = new Cache($storage, 'ns');
6060
$dependencies = [Cache::EXPIRATION => new DateTime];
6161

62-
$res = $cache->save('key', function () {
62+
@$res = $cache->save('key', function () { // @ deprecated
6363
return 'value';
6464
}, $dependencies);
6565
Assert::same('value', $res);

tests/Storages/FileStorage.closure.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Assert::null($cache->load($key));
2424

2525

2626
// Writing cache using Closure...
27-
$res = $cache->save($key, function () use ($value) {
27+
$res = @$cache->save($key, function () use ($value) { // @ deprecated
2828
return $value;
2929
});
3030

@@ -34,7 +34,7 @@ Assert::same($cache->load($key), $value);
3434

3535

3636
// Removing from cache using null callback...
37-
$cache->save($key, function () {
37+
@$cache->save($key, function () { // @ deprecated
3838
return null;
3939
});
4040

0 commit comments

Comments
 (0)