Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The package is blocked by Roave/SecurityAdvisories based on CVE-2024-55586 #314

Open
jkavalik opened this issue Dec 10, 2024 · 13 comments
Open

Comments

@jkavalik
Copy link

Advisory link - GHSA-f626-677r-j5vq
What I suppose was the "source" - https://www.csirt.sk/nette-framework-vulnerability-permits-sql-injection.html

Result - all versions other than 4.0 RC are disallowed.

Imho the app allowing unfiltered user input into the DB library is the definition of app bug, not library bug, and the "vulnerability" designations seems nonsense to me, but I am no security expert.

@mfn
Copy link

mfn commented Dec 10, 2024

Wow, this is such a shitshow.

Now this, last week there was also a similar thing -> Roave/SecurityAdvisories#137 (comment)

Granted, I'm not associated with either and the final verdict has not been spoken yet as to the validity of the claims, but being cautious here I too think the claim as presented on the external link page is not correct.

@dg
Copy link
Member

dg commented Dec 10, 2024

I found emails that they wrote to me about this. So I replied to them that it’s not a bug, that this behavior is intentional and is also documented. However, I have no idea if it’s possible to revoke such a CVE.

@mfn
Copy link

mfn commented Dec 10, 2024

The real travesty is that it seems anyone can publish any CVE for any package, without maintainer acknowledgement, but then you need to proof they're not valid etc. Something isn't right here.

@spaze
Copy link
Contributor

spaze commented Dec 11, 2024

@dg you can start by "improving" (their word, not mine) the GitHub Security Advisory (GHSA) here https://github.com/advisories/GHSA-f626-677r-j5vq/improve

Once/if the GHSA will be invalidated, Roave/SecurityAdvisories will/should stop blocking the installation (and the same for composer audit).

Then you can request a CVE rejection here https://cveform.mitre.org/ (Rejected CVE is an official term)

I wouldn't mind much if the CVE will not be rejected (heard there's a chance it won't, in general for various reasons, not this particular CVE) as long as the GHSA is.

I would "improve" the GHSA entry but I think it's better when the "improvement" comes from the maintainer, let's see.

@jkavalik
Copy link
Author

Great, so a "security expert" does not understand basic principles, says something about "spent time" but - THEIR nonsense stopped OUR CI in its tracks for days without any reason whatsoever...

@8ctopus
Copy link

8ctopus commented Dec 17, 2024

Any update on when this will be solved? Maybe @dg could release version 3.2.5, this way the block could be removed without waiting for the CVE rejection.

@otazniksk
Copy link

HINT:
Ignore this CVE in composer.json (temporary ignoring) for unlock

    "config": {
        "audit": {
            "ignore": {
                "CVE-2024-55586": "Visit https://github.com/nette/database/issues/314"
            }
        }
    },

spaze added a commit to spaze/SecurityAdvisoriesBuilder that referenced this issue Dec 17, 2024
Ignore GHSA-f626-677r-j5vq which is, per nette/database#314, a documented and intended feature. The PoC repo and the article from the GHSA are now gone and the CVE itself (CVE-2024-55586) is disputed.
@spaze
Copy link
Contributor

spaze commented Dec 17, 2024

I have created a PR Roave/SecurityAdvisoriesBuilder#759 to ignore the GHSA/CVE in roave/security-advisories.

@spaze
Copy link
Contributor

spaze commented Dec 17, 2024

The PR was merged and roave/security-advisories doesn't block nette/database anymore Roave/SecurityAdvisories@3076981

@8ctopus
Copy link

8ctopus commented Dec 17, 2024

@spaze Thank you!

@dg
Copy link
Member

dg commented Dec 17, 2024

It sucks that Composer itself started reporting it to me today, so I'll probably release a new version of the package.

@xabbuh
Copy link

xabbuh commented Dec 17, 2024

@dg you should be able to let Packagist ignore this advisory (see composer/packagist#1493 for such an example)

@spaze
Copy link
Contributor

spaze commented Dec 19, 2024

To recap, new 3.2.5 version was released yesterday (thanks @dg!) so composer doesn't complain anymore when installing or running composer audit, roave/security-advisories has the GHSA/CVE excluded so CI pipelines should be green once again, mine are.

The CVE itself is still in "disputed" status, "Awaiting Analysis".

@github-staff github-staff deleted a comment from dg Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants