Skip to content

Commit 297e73a

Browse files
committed
RequestFactory: script path is not detected from DOCUMENT_ROOT & SCRIPT_FILENAME (BC break)
see #31 Conflicts: src/Http/RequestFactory.php
1 parent 2988978 commit 297e73a

File tree

3 files changed

+2
-16
lines changed

3 files changed

+2
-16
lines changed

src/Http/RequestFactory.php

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,9 @@ public function createHttpRequest()
8989
$url->setQuery(isset($tmp[1]) ? $tmp[1] : '');
9090

9191
// detect script path
92-
if (isset($_SERVER['SCRIPT_NAME'])) {
93-
$script = $_SERVER['SCRIPT_NAME'];
94-
} elseif (isset($_SERVER['DOCUMENT_ROOT'], $_SERVER['SCRIPT_FILENAME'])
95-
&& strncmp($_SERVER['DOCUMENT_ROOT'], $_SERVER['SCRIPT_FILENAME'], strlen($_SERVER['DOCUMENT_ROOT'])) === 0
96-
) {
97-
$script = '/' . ltrim(strtr(substr($_SERVER['SCRIPT_FILENAME'], strlen($_SERVER['DOCUMENT_ROOT'])), '\\', '/'), '/');
98-
} else {
99-
$script = '/';
100-
}
101-
10292
$path = strtolower($path) . '/';
103-
$script = strtolower($script) . '/';
93+
$script = isset($_SERVER['SCRIPT_NAME']) ? $_SERVER['SCRIPT_NAME'] . '/' : '/';
94+
$script = strtolower($script);
10495
$max = min(strlen($path), strlen($script));
10596
for ($i = 0; $i < $max; $i++) {
10697
if ($path[$i] !== $script[$i]) {

tests/Http/Request.request.phpt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ $_SERVER = array(
1919
'REMOTE_ADDR' => '192.168.188.66',
2020
'REQUEST_METHOD' => 'GET',
2121
'REQUEST_URI' => '/file.php?x param=val.&pa%%72am=val2&param3=v%20a%26l%3Du%2Be)',
22-
'SCRIPT_FILENAME' => '/public_html/www/file.php',
2322
'SCRIPT_NAME' => '/file.php',
2423
);
2524

tests/Http/RequestFactory.scriptPath.phpt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ $factory = new RequestFactory;
1616
test(function() use ($factory) {
1717
$_SERVER = array(
1818
'REQUEST_URI' => '/projects/modules-usage/www/',
19-
'SCRIPT_FILENAME' => 'W:/projects/Modules-Usage/www/index.php',
2019
'SCRIPT_NAME' => '/projects/modules-usage/www/index.php',
2120
);
2221

@@ -27,7 +26,6 @@ test(function() use ($factory) {
2726
test(function() use ($factory) {
2827
$_SERVER = array(
2928
'REQUEST_URI' => '/projects/modules-usage/www/default/add-item',
30-
'SCRIPT_FILENAME' => 'W:/projects/Modules-Usage/www/index.php',
3129
'SCRIPT_NAME' => '/projects/Modules-Usage/www/index.php',
3230
);
3331

@@ -38,7 +36,6 @@ test(function() use ($factory) {
3836
test(function() use ($factory) {
3937
$_SERVER = array(
4038
'REQUEST_URI' => '/www/index.php',
41-
'SCRIPT_FILENAME' => 'w:\projects\modules-usage\www\index.php',
4239
'SCRIPT_NAME' => '/www/index.php',
4340
);
4441

@@ -49,7 +46,6 @@ test(function() use ($factory) {
4946
test(function() use ($factory) {
5047
$_SERVER = array(
5148
'REQUEST_URI' => '/www/',
52-
'SCRIPT_FILENAME' => 'w:\projects\modules-usage\www\index.php',
5349
'SCRIPT_NAME' => '/www/',
5450
);
5551

0 commit comments

Comments
 (0)