Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long titles are cut off in detailed view #26

Open
EnnoMeijers opened this issue Nov 17, 2024 · 1 comment
Open

Long titles are cut off in detailed view #26

EnnoMeijers opened this issue Nov 17, 2024 · 1 comment

Comments

@EnnoMeijers
Copy link
Contributor

When an item has a long titel and or description there is no scroll option in the detailed view to see all the text. The lines are just cut off (see http://localhost:1000/uva-beeldbank/boek/brief-van-bet-ha-waad-la-adat-yisrael-ha-maahedet-askenazim-u-sefaradim-jaffa-geschreven-door-nisim-ha-kohen-yaaqov-goldman-en-mordekay-adelmann-aan-pekidim-amarkalim-amsterdam-328 based on the UVA-Beeldbank config in https://github.com/netwerk-digitaal-erfgoed/makemyflix-configs/tree/main/UVA-Beeldbank)

@aabelmann
Copy link
Contributor

@EnnoMeijers - I am really wondering if we should solve this.
Your example (and the one I tested with) usually have a title that is soo long that it's shouldn't even be considered a title but more like a concatination of title, description and some properties (like author information)

This issue does't just affect the detail page but also the overview pages, for example:
Screenshot 2024-11-21 at 12 39 13

My monitor at home is big and even then it doesn't even come close to fitting.
I won't even check it on small screens or a mobile device.

Of course, I can make the title and description scrollable but this won't be very benificial to the UI/UX.
Unfortunately I can't make the page scrollable without making big changes to the current UX (mostly due to the slide effect we have on detail pages).
And even then we are still stuck with title that are too long for the overview pages.

So before I try to solve this, I would ask you to reconsider this issue, shouldn't this be solved at the source, updating the data to truncate the title to just a title instead of a concatination?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants