Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concrete data type #466

Open
odashi opened this issue Sep 10, 2022 · 2 comments
Open

Concrete data type #466

odashi opened this issue Sep 10, 2022 · 2 comments

Comments

@odashi
Copy link
Contributor

odashi commented Sep 10, 2022

FeatureTypes have the dtype member, which specifies the data type of corresponding data. However, this value is represented as str and it is unclear that what kind of values are valid for this member. Particularly, we need to:

  • Make a reference of valid dtype values. It should be either (1) defined by ourselves (in this repository), or (2) borrowed from other software.
  • Make a mechanism to restrict dtype member.

RFC: @neubig @pfliu-nlp

@neubig
Copy link
Contributor

neubig commented Sep 10, 2022

Yeah, this definitely seems reasonable to me. An Enum seems reasonable to me, but any other option sounds fine too.

@odashi
Copy link
Contributor Author

odashi commented Sep 10, 2022

Another problem is that JSON files involve different dtype definitions (one from ExplainaBoard, one from Datalab), which is a main source of confusion of my refactoring. We also need to consolidate them to just one type definition. I recommend not tot use Datalab's one and convert it to ExplainaBoard's data type once we loaded information from Datalab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants