Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jade is now pug #68

Open
Extarys opened this issue Jun 26, 2017 · 9 comments
Open

jade is now pug #68

Extarys opened this issue Jun 26, 2017 · 9 comments

Comments

@Extarys
Copy link

Extarys commented Jun 26, 2017

Just to let you know jade is now known as pug. Should change dep and test.

@kevintechie
Copy link

chateau won't install now.

@Extarys
Copy link
Author

Extarys commented Jul 1, 2017

I want my phpmyadmin for rethinkDB please :P

@neumino
Copy link
Owner

neumino commented Jul 2, 2017

Hum, I just tried, and this doesn't prevent chateau from being installed - There's just a warning during the installation

@Extarys
Copy link
Author

Extarys commented Jul 3, 2017

Thanks then will install (didn't try once I saw the dep with jade)

@kevintechie
Copy link

Definitely won't install for me. I'm installing globally over the previous version using NPM 5.0.4.

I get the following error:

npm ERR! code ETARGET
npm ERR! notarget No matching version found for jade@= 1.0.2
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget 
npm ERR! notarget It was specified as a dependency of 'chateau'
npm ERR! notarget 

@Extarys
Copy link
Author

Extarys commented Jul 4, 2017

@neumino Is it possible you already had the Jade dep installed on your machine?

@neumino
Copy link
Owner

neumino commented Jul 4, 2017

This works on my machine after cleaning up already installed packages: npm install [email protected]

For what it's worth (and what I remember), switching to pug is not a no-op, so there's a bit of work needed.

@Extarys
Copy link
Author

Extarys commented Jul 5, 2017

I created a pull request to switch from Jade to Pug - Wasn't able to fix the Add field in tables though.
@kevintechie If you have time, you can try this.

@sukrosono
Copy link

sukrosono commented Sep 27, 2017

i think it just good practice to keep dependency up to date, now i am about to listing the outdated warning when we install chateau :

  • jade now is pug
  • connect 2.x series is deprecated
  • transformers is deprecated use jstransformer
  • [email protected] -> minimatch 3.0.2 to avoid RefExp DoS issue
  • graceful-fs will fail on node release >= 7.0.0 . Please use graceful=fs 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants