Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-breaking space before inline reference/footnote not preserved in wiki node changes output #10

Open
Ambient-Impact opened this issue Aug 22, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Ambient-Impact
Copy link
Member

Ambient-Impact commented Aug 22, 2022

It's unclear if this is just in some cases or all cases, but a good example is in the Assassination of Xu Shaoyong and Yuri Golitsyn changes:

Screenshot 2022-08-22 at 07-37-02 Assassination of Xu Shaoyong and Yuri Golitsyn Changes since 2049_10_01 Omnipedia

Note the "[6]" wrapping to a new line. One solution may be to rework the non-breaking space as a <span> that wraps just a plain space, which should be preserved easily and can be made non-breaking via CSS.

Non-breaking space introduced in 0edeb03

We don't currently use the Typogrify module, but it may be worth looking into, if only for how it handles non-breaking spaces. It's unclear if CommonMark works well with this module or conflicts.

@Ambient-Impact Ambient-Impact added the bug Something isn't working label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant