-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all calls to node entity methods with service equivalents and/or Typed Entities #19
Closed
11 tasks done
Comments
Ambient-Impact
added a commit
that referenced
this issue
Aug 26, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-block
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-changes
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-discourse
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-menu
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-changes
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-menu
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-search
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-search
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-date
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-date
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-content
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-main-page
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-warmer
that referenced
this issue
Aug 27, 2023
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Aug 27, 2023
neurocracy/drupal-omnipedia-core#19 - Upgrading drupal/omnipedia_block (6.x-dev 8fcff1f => 6.x-dev bd52c20) - Upgrading drupal/omnipedia_changes (7.x-dev 0c4083f => 7.x-dev e410176) - Upgrading drupal/omnipedia_content (6.x-dev f5e8778 => 6.x-dev b88c721) - Upgrading drupal/omnipedia_core (5.x-dev f1600e2 => 5.x-dev bc8ab85) - Upgrading drupal/omnipedia_date (5.x-dev 2c0292f => 5.x-dev db770b5) - Upgrading drupal/omnipedia_discourse (1.x-dev fe116e3 => 1.x-dev e26870f) - Upgrading drupal/omnipedia_main_page (1.x-dev 0cc3071 => 1.x-dev 4c69959) - Upgrading drupal/omnipedia_menu (4.x-dev 90232ce => 4.x-dev 63a9d5a) - Upgrading drupal/omnipedia_search (4.x-dev 5ff3687 => 4.x-dev b6f04af) - Upgrading drupal/omnipedia_warmer (2.x-dev 7eeb6e4 => 2.x-dev 4a1f6f0)
Ambient-Impact
added a commit
that referenced
this issue
Aug 28, 2023
Ambient-Impact
added a commit
that referenced
this issue
Aug 28, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-changes
that referenced
this issue
Aug 28, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-date
that referenced
this issue
Aug 28, 2023
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Aug 28, 2023
neurocracy/drupal-omnipedia-core#4 neurocracy/drupal-omnipedia-core#19 - Upgrading drupal/omnipedia_changes (7.x-dev e410176 => 7.x-dev cf51eec) - Upgrading drupal/omnipedia_core (5.x-dev 1d41a90 => 5.x-dev eeb1426) - Upgrading drupal/omnipedia_date (5.x-dev db770b5 => 5.x-dev 5cefade)
Ambient-Impact
added a commit
that referenced
this issue
Aug 28, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-date
that referenced
this issue
Aug 28, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-main-page
that referenced
this issue
Aug 28, 2023
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Aug 28, 2023
- Upgrading drupal/omnipedia_core (5.x-dev eeb1426 => 5.x-dev 99b22eb) neurocracy/drupal-omnipedia-core#4 neurocracy/drupal-omnipedia-core#19
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Aug 28, 2023
- Upgrading drupal/omnipedia_date (5.x-dev 5cefade => 5.x-dev 08a8333) - Upgrading drupal/omnipedia_main_page (1.x-dev 4c69959 => 1.x-dev 7d8d93c) neurocracy/drupal-omnipedia-core#4 neurocracy/drupal-omnipedia-core#19
Ambient-Impact
changed the title
Replace all calls to node entity methods with service equivalents
Replace all calls to node entity methods with service equivalents and/or Typed Entities
Aug 28, 2023
3 tasks
Ambient-Impact
added a commit
that referenced
this issue
Sep 26, 2023
Ambient-Impact
added a commit
that referenced
this issue
Sep 26, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-attached-data
that referenced
this issue
Sep 26, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-menu
that referenced
this issue
Sep 26, 2023
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Sep 26, 2023
- Upgrading drupal/omnipedia_attached_data (4.x-dev 12ca24d => 4.x-dev 02bc3e7) - Upgrading drupal/omnipedia_menu (4.x-dev b2d8ef5 => 4.x-dev 966b922) Entity\OmnipediaAttachedData: Removed @see to custom node storage. Entity\WikiNodeMenuLink: Removed @see to custom node storage. neurocracy/drupal-omnipedia-core#4 neurocracy/drupal-omnipedia-core#19
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-block
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-changes
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-content
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-date
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-discourse
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-main-page
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-menu
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-search
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-warmer
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/drupal-omnipedia-site-theme
that referenced
this issue
Sep 27, 2023
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Sep 27, 2023
neurocracy/drupal-omnipedia-core#4 neurocracy/drupal-omnipedia-core#19 - Upgrading drupal/omnipedia_block (6.x-dev 9665587 => 6.x-dev 461e4e7) - Upgrading drupal/omnipedia_changes (7.x-dev ad2c068 => 7.x-dev 23446d3) - Upgrading drupal/omnipedia_content (6.x-dev fa2cf5e => 6.x-dev 9e0589f) - Upgrading drupal/omnipedia_date (5.x-dev 34fd5ef => 5.x-dev 7be1024) - Upgrading drupal/omnipedia_discourse (1.x-dev b495ac6 => 1.x-dev 70d23eb) - Upgrading drupal/omnipedia_main_page (1.x-dev f637986 => 1.x-dev 128a6c9) - Upgrading drupal/omnipedia_menu (4.x-dev 966b922 => 4.x-dev f18d884) - Upgrading drupal/omnipedia_search (4.x-dev a87c471 => 4.x-dev e78974d) - Upgrading drupal/omnipedia_site_theme (6.x-dev 551f9af => 6.x-dev 538baab) - Upgrading drupal/omnipedia_warmer (2.x-dev 4a1f6f0 => 2.x-dev 2cdcd67)
Ambient-Impact
added a commit
that referenced
this issue
Oct 1, 2023
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Oct 1, 2023
neurocracy/drupal-omnipedia-core#4 neurocracy/drupal-omnipedia-core#18 neurocracy/drupal-omnipedia-core#19 - Upgrading drupal/omnipedia_attached_data (4.x-dev 02bc3e7 => 4.x-dev faf659a) - Upgrading drupal/omnipedia_block (6.x-dev 461e4e7 => 6.x-dev 2c895ca) - Upgrading drupal/omnipedia_changes (7.x-dev 23446d3 => 7.x-dev 21f1e1f) - Upgrading drupal/omnipedia_content (6.x-dev 9e0589f => 6.x-dev bfdf20d) - Upgrading drupal/omnipedia_core (5.x-dev a8c6c09 => 6.x-dev 98ab752) - Upgrading drupal/omnipedia_date (5.x-dev 9617988 => 5.x-dev be98a11) - Upgrading drupal/omnipedia_discourse (1.x-dev 70d23eb => 1.x-dev 57ee699) - Upgrading drupal/omnipedia_main_page (1.x-dev fb9c0c9 => 1.x-dev 3b91949) - Upgrading drupal/omnipedia_media (7.x-dev 084e910 => 7.x-dev 569c1d9) - Upgrading drupal/omnipedia_menu (4.x-dev f18d884 => 4.x-dev 1773023) - Upgrading drupal/omnipedia_search (4.x-dev e78974d => 4.x-dev 54ab540) - Upgrading drupal/omnipedia_warmer (2.x-dev 2cdcd67 => 2.x-dev 2073f0b)
Ambient-Impact
added a commit
to neurocracy/omnipedia
that referenced
this issue
Oct 1, 2023
neurocracy/drupal-omnipedia-core#4 neurocracy/drupal-omnipedia-core#18 neurocracy/drupal-omnipedia-core#19 - Upgrading drupal/omnipedia_attached_data (4.x-dev 02bc3e7 => 4.x-dev faf659a) - Upgrading drupal/omnipedia_block (6.x-dev 461e4e7 => 6.x-dev 2c895ca) - Upgrading drupal/omnipedia_changes (7.x-dev 23446d3 => 7.x-dev 21f1e1f) - Upgrading drupal/omnipedia_content (6.x-dev 9e0589f => 6.x-dev bfdf20d) - Upgrading drupal/omnipedia_core (5.x-dev a8c6c09 => 6.x-dev 52f4440) - Upgrading drupal/omnipedia_date (5.x-dev 9617988 => 5.x-dev be98a11) - Upgrading drupal/omnipedia_discourse (1.x-dev 70d23eb => 1.x-dev 57ee699) - Upgrading drupal/omnipedia_main_page (1.x-dev fb9c0c9 => 1.x-dev 3b91949) - Upgrading drupal/omnipedia_media (7.x-dev 084e910 => 7.x-dev 569c1d9) - Upgrading drupal/omnipedia_menu (4.x-dev f18d884 => 4.x-dev 1773023) - Upgrading drupal/omnipedia_search (4.x-dev e78974d => 4.x-dev 54ab540) - Upgrading drupal/omnipedia_warmer (2.x-dev 2cdcd67 => 2.x-dev 2073f0b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #4 for more information.
Node::getWikiNodeType()
: this is a static method that just returns a constant; can be moved to a public constant on afinal
interface as a single source of truth.Node::getWikiNodeDateFieldName()
: this is a static method that just returns a constant; can be moved to a public constant on afinal
interface as a single source of truth.Node::isWikiNode()
: all uses of this can be pointed to the wiki node resolver service; note thatWikiNodeResolver::isWikiNode()
calls the node method of the same name, so that will have to be changed to either directly check the node's content type or re-implemented as a typed entity method.Node::getWikiNodeDate()
: this can be implemented as a typed entity method.Node::getWikiNodeRevisions()
: just a wiki node revision method wrapper; replaces all uses with service method.Node::getWikiNodeRevision()
: just a wiki node revision method wrapper; replaces all uses with service method.Node::hasPreviousWikiNodeRevision()
: see next method:Node::getPreviousWikiNodeRevision()
: this contains a lot of logic that should be moved to the wiki node revision service or a typed entity class.Node::isMainPage()
: this is just a wrapper around the main page service method; replace uses with service call.Node::isHiddenFromSearch()
: this mixes main page logic and the hidden from search field; rework so this module doesn't need to know about or use such a method; see Move the field_hide_from_search configuration to the omnipedia_search module if possible #2.Node::addRecentlyViewedWikiNode()
: this is just a wrapper around the wiki node viewed service; replace single instance with a call directly to the service.The text was updated successfully, but these errors were encountered: