Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink the date system and how dates are defined #3

Open
Ambient-Impact opened this issue Jul 10, 2023 · 0 comments
Open

Rethink the date system and how dates are defined #3

Ambient-Impact opened this issue Jul 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Ambient-Impact
Copy link
Member

Ambient-Impact commented Jul 10, 2023

The current system relies on a wiki node having one date, but this will change in neurocracy/drupal-omnipedia-core#10 which will require a partial or total rethink of how dates are defined.

The solution most like the current system would be to build a list of dates from those defined in wiki node body fields, but that's complicated and has most of the same issues the current system has.

A better solution may be to define dates explicitly as their own entities, which could make keeping a list of dates easier, as we could have an entity reference to all wiki nodes that reference them. We would need to build in a good amount of validation to ensure that dates are continuous and aren't missing dates in between; it may be best to not even expose the ability to set or change individual dates, but expose just the start and end dates as configurable, with the system creating or deleting dates as needed to fill the date range in; this would also need extra care if the start or end date is changed to be shorter, as this would require rewriting wiki node content and editors should not be able to do this without a big and obvious confirm step that lists all the nodes that would be affected and what the changes would be.

See also #1

@Ambient-Impact Ambient-Impact added the enhancement New feature or request label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant