-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Longitudinal stability of brain and spinal cord quantitative MRI measures #15
Comments
@roboneuro commands |
Hello @agahkarakuzu, here are the things you can ask me to do:
|
@roboneuro generate pdf |
Reason is that affiliation 4 is not listed:
The same goes for the other affilitations 4-7. |
Woops - I forgot the affiliations, my bad. Adding them now! |
@roboneuro generate pdf |
Thanks @mathieuboudreau ! Another major issue has to do with how the repository is organized. NeuroLibre expects Unless the repo follows this structure, we are not going to be able to proceed. |
Sorry @agahkarakuzu ! You're right - I forgot because I knew I did it for the T1 mapping challenge one, and for some reason thought I had also done if for this one. I will update and let you know when it's done |
@roboneuro check repository |
|
Wordcount for |
Failed to discover a valid open source license |
Failed to discover a |
@mathieuboudreau just a heads up, the command you've just run has not been tailored for neurolibre specific checks yet. |
Ok! Thanks! I've made the changes, would |
@roboneuro build book |
Can't perform this without reviewers |
Please wait for me to assign a reviewer, then we'll go through boom build in the review issue. |
Sorry about that @agahkarakuzu ! I wanted to test that I got the repository directory structure correct, so I checked the documentation https://docs.neurolibre.org/en/latest/TEST_SUBMISSION.html#testing-on-neurolibre-servers but the roboneuro preview service that's linked there (https://roboneuro.herokuapp.com) appears to be down, so I thought trying that command here might of tested the same thing. I'll wait for further instructions |
@agahkarakuzu following up on your comment #14 (comment) in my other submission, I've pre-emptively updated the repo for this submission to adhere to your requests (removed the duplicate requirements.txt, archived the data in a zip file, used repo2data to load it, and added a postBuild to clone the code repo I need) |
That's great, thank you so much @mathieuboudreau! I am working on some OHBM video submissions today, I'll get to this once I am done with that :) |
@mathieuboudreau can you add |
Done ✅ |
@roboneuro commands |
Hello @agahkarakuzu, here are the things you can ask me to do:
|
🔴 Binder build has failed 🥀Status: Failed ℹ️ See details
|
🥀 We ran into a problem building your book. Please see the log files below. BinderHub build log
If the BinderHub build looks OK, please see the Jupyter Book build log(s) below. I could not find any book log for courtois-neuromod/anat-processing-paper at d2351668b1f74462387ef85c0baa7bb6057efa3e🐞 After inspecting the logs above, you can interactively debug your notebooks on our BinderHub server. For guidelines, please see the relevant documentation. |
@roboneuro build book |
🔴 Binder build has failed 🥀Status: Failed ℹ️ See details
|
🥀 We ran into a problem building your book. Please see the log files below. BinderHub build log
If the BinderHub build looks OK, please see the Jupyter Book build log(s) below. I could not find any book log for courtois-neuromod/anat-processing-paper at faefd2e345d1b84aee01b1f71f61441f17848d34🐞 After inspecting the logs above, you can interactively debug your notebooks on our BinderHub server. For guidelines, please see the relevant documentation. |
I can't seem to find it - can you confirm @agahkarakuzu ? |
@roboneuro build book |
🔴 Binder build has failed 🥀Status: Failed ℹ️ See details
|
🥀 We ran into a problem building your book. Please see the log files below. BinderHub build log
If the BinderHub build looks OK, please see the Jupyter Book build log(s) below. I could not find any book log for courtois-neuromod/anat-processing-paper at 4c64985dcd074012c8dad8c57f6fbdd4189947a0🐞 After inspecting the logs above, you can interactively debug your notebooks on our BinderHub server. For guidelines, please see the relevant documentation. |
This one probably needs /home/jovyan/data/... (abs path) as the postBuild is attempting to use root dir otherwise. |
@roboneuro build book |
🔴 Binder build has failed 🥀Status: Failed ℹ️ See details
|
🥀 We ran into a problem building your book. Please see the log files below. BinderHub build log
If the BinderHub build looks OK, please see the Jupyter Book build log(s) below. I could not find any book log for courtois-neuromod/anat-processing-paper at 9836694701c515c010bd76dc88aca08a52f1802e🐞 After inspecting the logs above, you can interactively debug your notebooks on our BinderHub server. For guidelines, please see the relevant documentation. |
From the report above, that absolute path doesn't appear to exist. I
|
@agahkarakuzu any other ideas on how to access the neurolibre data in postbuild? Is it even possible? (I thought it should, but maybe I'm misunderstanding when the data is being mounted to the image) |
@roboneuro generate pdf |
Leaving this here as this command is trying to copy data before it becomes available:
|
So the data can't be available in either the Docker build stage or the postbuild stage? That means I would need to copy it inside the jupyter notebook after the image is running? |
Both build and postbuild stages are taking place in the build pod, and the data is mounted to the user pod that is spawn from the image built by the build pod :)
I'll see what we can do for that, but first I need to debug something with repo2data to download a file using python... The simplest thing you'd expect it would achieve. |
😅 |
@roboneuro build book |
🔴 Binder build has failed 🥀Status: Failed ℹ️ See details
|
OK good, not I can deal with this in the review issue, I'll close the pre-review and start the review. |
@roboneuro start review |
OK, I've started the review over in openjournals/joss-reviews#18. |
Bug? |
It was, fixed though. Issue #10 should have shown the correct one on closure. |
Got it, just something I had just noticed haha. Thanks! |
Submitting author: @mathieuboudreau (Mathieu Boudreau)
Repository: https://github.com/courtois-neuromod/anat-processing-paper
Branch with paper.md (empty if default branch): main
Version: v1.0.0
Editor: @agahkarakuzu
Reviewers: @agahkarakuzu
Managing EiC: Agah Karakuzu
Status
Status badge code:
Author instructions
Thanks for submitting your paper to NeuroLibre @mathieuboudreau. Currently, there isn't a NeuroLibre editor assigned to your paper.
The AEiC suggestion for the handling editor is @pbellec.
@mathieuboudreau if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for NeuroLibre and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The NeuroLibre submission bot @roboneuro is here to help you find and assign reviewers and start the main review. To find out what @roboneuro can do for you type:
The text was updated successfully, but these errors were encountered: