Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in stim_PulseTrain #1

Open
fguerit opened this issue Oct 10, 2023 · 1 comment
Open

Fix bug in stim_PulseTrain #1

fguerit opened this issue Oct 10, 2023 · 1 comment

Comments

@fguerit
Copy link

fguerit commented Oct 10, 2023

hi @neurongeek ;)

I think it's probably beacuse of a rounding error with the use of ceil but sometimes this function crashes, and that can be fixed by changing:

Istim = ModWave .* Istim;

to

Istim = ModWave .* Istim(1:length(ModWave));

happy to submit a change in the code, but need to be given rights to contribute to this repo

@neurongeek
Copy link
Owner

hi @fguerit,

I believe you are right, it's probably because different sizes of the carrier vs the modulator arrays. I am adding you to the edit rights! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants