Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are missing in dcm-oklahoma #339

Open
NathanMolinier opened this issue Dec 2, 2024 · 6 comments
Open

Images are missing in dcm-oklahoma #339

NathanMolinier opened this issue Dec 2, 2024 · 6 comments

Comments

@NathanMolinier
Copy link

NathanMolinier commented Dec 2, 2024

Description

I noticed that some spinal cord segmentation did not have their corresponding raw image:

ValueError: missing files:
/home/GRAMES.POLYMTL.CA/p118739/data/datasets/dcm-oklahoma/sub-CSM050/anat/sub-CSM050_flip-1_mt-off_MTS.nii.gz
/home/GRAMES.POLYMTL.CA/p118739/data/datasets/dcm-oklahoma/sub-CSM129/anat/sub-CSM129_flip-1_mt-off_MTS.nii.gz
/home/GRAMES.POLYMTL.CA/p118739/data/datasets/dcm-oklahoma/sub-CSM130/anat/sub-CSM130_flip-1_mt-off_MTS.nii.gz
/home/GRAMES.POLYMTL.CA/p118739/data/datasets/dcm-oklahoma/sub-CSM135/anat/sub-CSM135_flip-1_mt-off_MTS.nii.gz
/home/GRAMES.POLYMTL.CA/p118739/data/datasets/dcm-oklahoma/sub-CSM137/anat/sub-CSM137_flip-1_mt-off_MTS.nii.gz
/home/GRAMES.POLYMTL.CA/p118739/data/datasets/dcm-oklahoma/sub-CSM138/anat/sub-CSM138_flip-1_mt-off_MTS.nii.gz
/home/GRAMES.POLYMTL.CA/p118739/data/datasets/dcm-oklahoma/sub-CSM142/anat/sub-CSM142_flip-1_mt-off_MTS.nii.gz

Do you have any information about that @valosekj ?

@valosekj
Copy link
Member

Sorry for the late response. Unfortunately, I do not have any additional details regarding these missing MT files.

@NathanMolinier
Copy link
Author

No problem ! Should we remove them from the dataset ?

@valosekj
Copy link
Member

valosekj commented Jan 6, 2025

What about keeping them? We might get the raw images in the future.

@mguaypaq
Copy link
Member

mguaypaq commented Jan 6, 2025

I guess there are two options, here are some pros and cons:

  • Delete the extra segmentations
    • Pro: avoid errors in processing scripts which don't expect this situation.
    • Pro: if we get raw images, we can recover the segmentations from the git history.
    • Con: if we get raw images, we might forget that the segmentations exist.
  • Keep the extra segmentations
    • Pro: if we get raw images, we won't accidentally forget that we have these segmentations.
    • Con: the segmentations might not match the eventual raw images? We might forget to check this.
    • Con: the situation is unusual.

@NathanMolinier
Copy link
Author

Personally I would prefer the first option, deleting these images would be cleaner to avoid mistakes. I created this issue based on an error that I got from one of my scripts.

Also as mentioned by @mguaypaq, if we can use git to recover them I guess we don't lose any work.

@mguaypaq
Copy link
Member

mguaypaq commented Jan 7, 2025

Also, if we want a better chance of remembering and finding the "deleted" masks, we can keep a branch or a tag with a hint in the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants