Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill missing data in images with NaNs #274

Closed
tsalo opened this issue Jun 25, 2020 · 7 comments
Closed

Fill missing data in images with NaNs #274

tsalo opened this issue Jun 25, 2020 · 7 comments
Labels
enhancement New feature or request ibma Issues/PRs pertaining to image-based meta-analysis

Comments

@tsalo
Copy link
Member

tsalo commented Jun 25, 2020

This is related to neurostuff/PyMARE#42 and neurostuff/PyMARE#44, as well as to #231 (comment).

We can include this step in the _preprocess_inputs method in image-based meta-analysis estimators called by fit().

@nicholst what do you think of this as a solution to your comment about varying degrees of freedom in IBMAs?

@tsalo tsalo added the enhancement New feature or request label Jun 25, 2020
@nicholst
Copy link

nicholst commented Jun 25, 2020 via email

@tsalo
Copy link
Member Author

tsalo commented Jun 25, 2020

The only problem with explicit masks is that we have to pass a 2D array into PyMARE, which would increase complexity on NiMARE's side by a fair amount.

If we masked out studies with missing data for each voxel, then we would have to loop through unique combinations of studies with data to identify matching voxels, build 2D arrays for those voxels, run the PyMARE estimator on each group separately, and then merge the results back into a map at the end.

EDIT: I think we could pass in an optional numpy mask with the 2D array to PyMARE, but that would depend on what @tyarkoni wants PyMARE to support.

@nicholst
Copy link

nicholst commented Jun 25, 2020 via email

@tsalo
Copy link
Member Author

tsalo commented Oct 3, 2020

Please forgive me if we've discussed this before, but have we considered (at least in the architecture if not the current implementation) the possibility of voxel-wise-varying sample size?

It's now an edge case, but with larger and larger N (for an individual, non-meta analysis), you have the problem of ever eroding analysis mask since all voxels are required. We are now building tools that allow the number of subjects contributing to an analysis vary by voxel (within limits, of course).

Originally posted by @nicholst in #231 (comment)

@nicholst I don't want to open a new issue about it, but is Cutler, Radua, & Campbell-Meiklejohn (2018) what you were talking about as a method for dealing with varying brain coverage across maps?

@nicholst
Copy link

nicholst commented Oct 3, 2020

Thanks for the ref @tsalo, I hadn't seen that.

I didn't have a particular correction in mind. While the equations they present for one-sample random effects meta-analyses are handy, I prefer to see things in terms of a meta-regression where you have an arbtrary X matrix. For that, I don't know of any such short cuts... you simply have to run the model with the rows of Y and X for which you have complete data.

@tsalo
Copy link
Member Author

tsalo commented Oct 3, 2020

Ah, thank you for the clarification. It sounds like we can/should just let PyMARE handle it then.

@tsalo tsalo added the ibma Issues/PRs pertaining to image-based meta-analysis label Dec 28, 2020
@tsalo
Copy link
Member Author

tsalo commented Jun 3, 2022

Since we've decided to let PyMARE handle any missing data issues, I think we can close this.

@tsalo tsalo closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ibma Issues/PRs pertaining to image-based meta-analysis
Projects
None yet
Development

No branches or pull requests

2 participants