-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill missing data in images with NaNs #274
Comments
I’ve slipped into FSL’s sphere of avoiding implicit NA masking at all costs
and using explicit masks. But if you’re OK with NA masking go for it.
--
…_________________________________________________________
Thomas Nichols, PhD
Professor of Neuroimaging Statistics
Nuffield Department of Population Health | University of Oxford
Big Data Institute | Li Ka Shing Centre for Health Information and Discovery
Old Road Campus | Headington | Oxford | OX3 7LF | United Kingdom
T: +44 1865 743590 | E: [email protected]
W: http://nisox.org | http://www.bdi.ox.ac.uk
|
The only problem with explicit masks is that we have to pass a 2D array into PyMARE, which would increase complexity on NiMARE's side by a fair amount. If we masked out studies with missing data for each voxel, then we would have to loop through unique combinations of studies with data to identify matching voxels, build 2D arrays for those voxels, run the PyMARE estimator on each group separately, and then merge the results back into a map at the end. EDIT: I think we could pass in an optional |
I'm fine with it... so do what makes sense.
|
@nicholst I don't want to open a new issue about it, but is Cutler, Radua, & Campbell-Meiklejohn (2018) what you were talking about as a method for dealing with varying brain coverage across maps? |
Thanks for the ref @tsalo, I hadn't seen that. I didn't have a particular correction in mind. While the equations they present for one-sample random effects meta-analyses are handy, I prefer to see things in terms of a meta-regression where you have an arbtrary X matrix. For that, I don't know of any such short cuts... you simply have to run the model with the rows of Y and X for which you have complete data. |
Ah, thank you for the clarification. It sounds like we can/should just let PyMARE handle it then. |
Since we've decided to let PyMARE handle any missing data issues, I think we can close this. |
This is related to neurostuff/PyMARE#42 and neurostuff/PyMARE#44, as well as to #231 (comment).
We can include this step in the
_preprocess_inputs
method in image-based meta-analysis estimators called byfit()
.@nicholst what do you think of this as a solution to your comment about varying degrees of freedom in IBMAs?
The text was updated successfully, but these errors were encountered: