Q: How to test correctness of patches against asm files

[mirabilos]

Hi,

in the same vain as neutrinolabs/librfxcodec#16 I will need to change:

• module/x86/a8r8g8b8_to_a8b8g8r8_box_x86_sse2.asm
• module/x86/a8r8g8b8_to_nv12_box_x86_sse2.asm
• module/x86/i420_to_rgb32_x86_sse2.asm
• module/x86/uyvy_to_rgb32_x86_sse2.asm
• module/x86/yuy2_to_rgb32_x86_sse2.asm
• module/x86/yv12_to_rgb32_x86_sse2.asm

How can I test these?

[proski]

You would need to write a test that links against libxorgxrdp.la and runs the functions you modify.

[mirabilos]

I was kinda hoping for an existing test, as I have no idea which (input, output) tuples are to be expected (I don’t even know what these functions do, I merely transfer them mechanically with my (pretty excellent) i386 asm skills).