From 42916744eec2879af8a923a6cfd697f0a1557b55 Mon Sep 17 00:00:00 2001 From: Whatstone <166147148+whatston3@users.noreply.github.com> Date: Sun, 11 Aug 2024 22:53:56 -0400 Subject: [PATCH 01/39] Add Paradise fire extinguisher with attribution (#1851) --- .../Catalog/Cargo/cargo_emergency.yml | 2 +- .../Objects/Misc/fire_extinguisher.yml | 4 +-- .../Construction/Graphs/furniture/altars.yml | 2 +- .../fire_extinguisher_closed.png | Bin 0 -> 303 bytes .../fire_extinguisher_open.png | Bin 0 -> 315 bytes .../fire_extinguisher.rsi/inhand-left.png | Bin 0 -> 284 bytes .../fire_extinguisher.rsi/inhand-right.png | Bin 0 -> 326 bytes .../Misc/fire_extinguisher.rsi/meta.json | 26 ++++++++++++++++++ 8 files changed, 30 insertions(+), 4 deletions(-) create mode 100644 Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/fire_extinguisher_closed.png create mode 100644 Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/fire_extinguisher_open.png create mode 100644 Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/inhand-left.png create mode 100644 Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/inhand-right.png create mode 100644 Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/meta.json diff --git a/Resources/Prototypes/Catalog/Cargo/cargo_emergency.yml b/Resources/Prototypes/Catalog/Cargo/cargo_emergency.yml index d5ecc285ceb8..66db9df98f69 100644 --- a/Resources/Prototypes/Catalog/Cargo/cargo_emergency.yml +++ b/Resources/Prototypes/Catalog/Cargo/cargo_emergency.yml @@ -13,7 +13,7 @@ id: EmergencyFire abstract: true # Frontier icon: - sprite: Objects/Misc/fire_extinguisher.rsi + sprite: _NF/Objects/Misc/fire_extinguisher.rsi # Frontier state: fire_extinguisher_closed product: CrateEmergencyFire cost: 1500 diff --git a/Resources/Prototypes/Entities/Objects/Misc/fire_extinguisher.yml b/Resources/Prototypes/Entities/Objects/Misc/fire_extinguisher.yml index 89b421c97d4d..0e1bf5d43e9b 100644 --- a/Resources/Prototypes/Entities/Objects/Misc/fire_extinguisher.yml +++ b/Resources/Prototypes/Entities/Objects/Misc/fire_extinguisher.yml @@ -5,12 +5,12 @@ description: It extinguishes fires. components: - type: Sprite - sprite: Objects/Misc/fire_extinguisher.rsi + sprite: _NF/Objects/Misc/fire_extinguisher.rsi # Frontier layers: - state: fire_extinguisher_closed map: [ "enum.ToggleVisuals.Layer" ] - type: Item - sprite: Objects/Misc/fire_extinguisher.rsi + sprite: _NF/Objects/Misc/fire_extinguisher.rsi # Frontier size: Normal - type: SolutionContainerManager solutions: diff --git a/Resources/Prototypes/_NF/Recipes/Construction/Graphs/furniture/altars.yml b/Resources/Prototypes/_NF/Recipes/Construction/Graphs/furniture/altars.yml index 7f99133ca5c0..0fe0c34b382c 100644 --- a/Resources/Prototypes/_NF/Recipes/Construction/Graphs/furniture/altars.yml +++ b/Resources/Prototypes/_NF/Recipes/Construction/Graphs/furniture/altars.yml @@ -66,7 +66,7 @@ name: fire extinguisher store: altar_component icon: - sprite: Objects/Misc/fire_extinguisher.rsi + sprite: _NF/Objects/Misc/fire_extinguisher.rsi # Frontier state: fire_extinguisher_closed - component: ExtinguishOnInteract # Not exclusive to candles I believe, but it's something that narrows down the list name: candle (any) diff --git a/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/fire_extinguisher_closed.png b/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/fire_extinguisher_closed.png new file mode 100644 index 0000000000000000000000000000000000000000..b84389a06bd18e2ef60cf5e4bc94fde649b421bf GIT binary patch literal 303 zcmV+~0nq-5P)h%44 zdwb>O<+irASy@>&H#$*NRW~;`At5GD0UV44BI$H=x&;NL007xIIOa`FiHC=UiIls+ z$>iti!sI6h00001bW%=J06^y0W&i*Hp-DtRR5*>b($NmXAP5Ces3Kz3t@{7}I@;}R zVv{!I^`2Zv6yTvjJc*YX(0FnFB%b7xn25kTyPZM^j1CdUf&#_J=>6h&xPw9jU}o=7 zdj{kHB1w&?_`hTavgTY$siKNUH%MOBT5A#GN(C=%$kzeIDcCD+19}>S_Xz;leqb{} zJ3upmwAOoX&0Hb*0QL>@xA=h%44 zdwb>O<+irASy@>&H##>rH&IkoAt5GD0UV44BI$H=x&;NL007xIIOa`FiHC=UiIls+ z$>itiGCWwu00001bW%=J06^y0W&i*Htw}^dR5*>b(%lZjAP5Cuse;A7t@i!jb!d07 zWTMHMaeKbt3DKB84ZtGaWv^8FPC9gOqoj!TAM{*A2w|50GA|%_3Obz{x$^)3 N002ovPDHLkV1iTDfUN)k literal 0 HcmV?d00001 diff --git a/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/inhand-left.png b/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/inhand-left.png new file mode 100644 index 0000000000000000000000000000000000000000..fb697da3566cbff8c83c5fb85a8fd37c93211b3c GIT binary patch literal 284 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=k3C%+Ln`LHy|t0|kbyw!L-uLa z-x4&-JUqQm3-vtoosf~a>BvO^LB$C&H85P8wNd%I@-DKEoY=CdBuG2M&M++VT# ze!S~iHjkhBp>Llq-NpMth&LnFA^Y9^+kgCPOHO=0#|$x_fnopJl==guMqBRZo=MbK z2(SOm%va60^UgQ+JAMvbAFm#s{)Y8Q(Ovl!hB9C0J>U84@86OcY+Ljem~MZ+@~X`I czl;k`@Y-kuSKmF&c@AWxr>mdKI;Vst0LVXiZvX%Q literal 0 HcmV?d00001 diff --git a/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/inhand-right.png b/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/inhand-right.png new file mode 100644 index 0000000000000000000000000000000000000000..e06a534c249a612e6885170923ec12052bd1726d GIT binary patch literal 326 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=jKx9jP7LeL$-D%z89ZGaLn`LH zy=BPPI%*G4w>1fRrj>sIdbIMF>QfQIvi~p31Z=4PyP#WJ2gCH-9B?F z&>#?aaPs4Ztv4iVemsfgon!1d&9iJ@%+#yL?cZzWfBu|y_H15e)^?Mvhb(`8RZN*A zdd}8p`=@Wu-u+_o3Hmg(<)g|gNvG=!|K2{8p8MW(3!4rTbBC*k*d_wJv z=s1Wi3=Gc_@~YW>^<=d Q`XGxuUHx3vIVCg!0Jvd|4*&oF literal 0 HcmV?d00001 diff --git a/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/meta.json b/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/meta.json new file mode 100644 index 000000000000..6f4150e8f7cc --- /dev/null +++ b/Resources/Textures/_NF/Objects/Misc/fire_extinguisher.rsi/meta.json @@ -0,0 +1,26 @@ +{ + "version": 1, + "license": "CC-BY-SA-3.0", + "copyright": "Taken from https://github.com/tgstation/tgstation at commit 9bebd81ae0b0a7f952b59886a765c681205de31f", + "copyright": "fire_extinguisher_open, fire_extinguisher_open taken from Paradise at commit https://github.com/ParadiseSS13/Paradise/commit/fd1e9ec033f1af410bb31e883ce0b19902d305c3", + "size": { + "x": 32, + "y": 32 + }, + "states": [ + { + "name": "fire_extinguisher_open" + }, + { + "name": "fire_extinguisher_closed" + }, + { + "name": "inhand-right", + "directions": 4 + }, + { + "name": "inhand-left", + "directions": 4 + } + ] +} From 5afd8c53c0a886b95c2f593a3879fc07ba53fc10 Mon Sep 17 00:00:00 2001 From: GreaseMonk <1354802+GreaseMonk@users.noreply.github.com> Date: Mon, 12 Aug 2024 21:11:25 +0200 Subject: [PATCH 02/39] Add currency notation (#1768) * Implement currency string notation * Darin fix * Update Resources/Locale/en-US/_NF/store/uplink-catalog.ftl Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Resources/Prototypes/_NF/Catalog/Fills/Items/briefcases.yml Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Content.Client/Cargo/UI/CargoConsoleMenu.xaml Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Resources/Changelog/Changelog.yml Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Resources/Prototypes/_NF/Catalog/Fills/Items/briefcases.yml Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Resources/Prototypes/_NF/Catalog/Fills/Items/briefcases.yml Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Resources/Prototypes/_NF/Catalog/Fills/Items/briefcases.yml Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Update Resources/Prototypes/_NF/Catalog/Fills/Items/briefcases.yml Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Currency-specific conversion functions --------- Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> Co-authored-by: Whatstone Co-authored-by: Dvir <39403717+dvir001@users.noreply.github.com> Co-authored-by: Checkraze <71046427+Cheackraze@users.noreply.github.com> --- Content.Client/Bank/UI/BankATMMenu.xaml.cs | 7 +- .../Bank/UI/StationBankATMMenu.xaml.cs | 7 +- Content.Client/Bank/UI/WithdrawBankATMMenu.cs | 5 +- Content.Client/Cargo/UI/BountyEntry.xaml.cs | 3 +- Content.Client/Cargo/UI/CargoConsoleMenu.xaml | 2 +- .../Cargo/UI/CargoConsoleMenu.xaml.cs | 7 +- .../Cargo/UI/CargoPalletMenu.xaml.cs | 3 +- .../Lobby/UI/Loadouts/LoadoutWindow.xaml.cs | 6 +- Content.Client/PDA/PdaMenu.xaml.cs | 5 +- .../Shipyard/UI/ShipyardConsoleMenu.xaml.cs | 9 ++- Content.Client/Store/Ui/StoreMenu.xaml.cs | 3 +- .../Store/Ui/StoreWithdrawWindow.xaml.cs | 3 +- .../UI/VendingMachineMenu.xaml.cs | 9 ++- .../BountyContractUiFragmentListEntry.xaml.cs | 4 +- .../UI/ContrabandPalletMenu.xaml.cs | 4 +- .../_NF/Pirate/UI/PirateBountyEntry.xaml.cs | 3 +- .../Cargo/Systems/CargoSystem.Bounty.cs | 3 +- .../_NF/Cargo/CargoSystem.PirateBounty.cs | 5 +- .../Preferences/HumanoidCharacterProfile.cs | 12 +-- .../_NF/Bank/BankSystemExtensions.cs | 80 +++++++++++++++++++ Resources/Changelog/Changelog.yml | 12 +-- .../en-US/_NF/bank/bank-ATM-component.ftl | 2 - .../Locale/en-US/_NF/loadouts/loadouts.ftl | 4 +- .../humanoid-character-profile.ftl | 2 - .../shipyard/shipyard-console-component.ftl | 1 - .../Locale/en-US/_NF/store/uplink-catalog.ftl | 2 +- .../en-US/cargo/cargo-bounty-console.ftl | 4 +- .../en-US/cargo/cargo-console-component.ftl | 1 - .../_NF/Catalog/Fills/Items/briefcases.yml | 10 +-- 29 files changed, 154 insertions(+), 64 deletions(-) create mode 100644 Content.Shared/_NF/Bank/BankSystemExtensions.cs delete mode 100644 Resources/Locale/en-US/_NF/preferences/humanoid-character-profile.ftl diff --git a/Content.Client/Bank/UI/BankATMMenu.xaml.cs b/Content.Client/Bank/UI/BankATMMenu.xaml.cs index e60d878fa856..d72ab5315d9c 100644 --- a/Content.Client/Bank/UI/BankATMMenu.xaml.cs +++ b/Content.Client/Bank/UI/BankATMMenu.xaml.cs @@ -4,6 +4,7 @@ * See AGPLv3.txt for details. */ using Content.Client.UserInterface.Controls; +using Content.Shared._NF.Bank; using Robust.Client.AutoGenerated; using Robust.Client.UserInterface.Controls; using Robust.Client.UserInterface.XAML; @@ -27,14 +28,14 @@ public BankATMMenu() public void SetBalance(int amount) { - BalanceLabel.Text = Loc.GetString("bank-atm-menu-cash-amount", ("amount", amount.ToString())); + BalanceLabel.Text = BankSystemExtensions.ToSpesoString(amount); } public void SetDeposit(int amount) { DepositButton.Disabled = amount <= 0; if (amount >= 0) // Valid - DepositLabel.Text = Loc.GetString("bank-atm-menu-cash-amount", ("amount", amount.ToString())); + DepositLabel.Text = BankSystemExtensions.ToSpesoString(amount); else DepositLabel.Text = Loc.GetString("bank-atm-menu-cash-error"); } @@ -59,6 +60,6 @@ private void OnAmountChanged(LineEdit.LineEditEventArgs args) if (int.TryParse(args.Text, out var amount)) { Amount = amount; - } + } } } diff --git a/Content.Client/Bank/UI/StationBankATMMenu.xaml.cs b/Content.Client/Bank/UI/StationBankATMMenu.xaml.cs index bbc0e9a55d28..bee11b750fbc 100644 --- a/Content.Client/Bank/UI/StationBankATMMenu.xaml.cs +++ b/Content.Client/Bank/UI/StationBankATMMenu.xaml.cs @@ -4,6 +4,7 @@ * See AGPLv3.txt for details. */ using Content.Client.UserInterface.Controls; +using Content.Shared._NF.Bank; using Robust.Client.AutoGenerated; using Robust.Client.UserInterface.Controls; using Robust.Client.UserInterface.XAML; @@ -41,14 +42,14 @@ private void OnReasonSelected(OptionButton.ItemSelectedEventArgs args) } public void SetBalance(int amount) { - BalanceLabel.Text = Loc.GetString("bank-atm-menu-cash-amount", ("amount", amount.ToString())); + BalanceLabel.Text = BankSystemExtensions.ToSpesoString(amount); } public void SetDeposit(int amount) { DepositButton.Disabled = amount <= 0; if (amount >= 0) // Valid - DepositLabel.Text = Loc.GetString("bank-atm-menu-cash-amount", ("amount", amount.ToString())); + DepositLabel.Text = BankSystemExtensions.ToSpesoString(amount); else DepositLabel.Text = Loc.GetString("bank-atm-menu-cash-error"); } @@ -74,7 +75,7 @@ private void OnAmountChanged(LineEdit.LineEditEventArgs args) if (int.TryParse(args.Text, out var amount)) { Amount = amount; - } + } } private void OnDescChanged(LineEdit.LineEditEventArgs args) diff --git a/Content.Client/Bank/UI/WithdrawBankATMMenu.cs b/Content.Client/Bank/UI/WithdrawBankATMMenu.cs index 4a5cbd41a554..78f61ec94e50 100644 --- a/Content.Client/Bank/UI/WithdrawBankATMMenu.cs +++ b/Content.Client/Bank/UI/WithdrawBankATMMenu.cs @@ -4,6 +4,7 @@ * See AGPLv3.txt for details. */ using Content.Client.UserInterface.Controls; +using Content.Shared._NF.Bank; using Robust.Client.AutoGenerated; using Robust.Client.UserInterface.Controls; using Robust.Client.UserInterface.XAML; @@ -26,7 +27,7 @@ public WithdrawBankATMMenu() public void SetBalance(int amount) { - BalanceLabel.Text = Loc.GetString("bank-atm-menu-cash-amount", ("amount", amount.ToString())); + BalanceLabel.Text = BankSystemExtensions.ToSpesoString(amount); } public void SetEnabled(bool enabled) @@ -44,6 +45,6 @@ private void OnAmountChanged(LineEdit.LineEditEventArgs args) if (int.TryParse(args.Text, out var amount)) { Amount = amount; - } + } } } diff --git a/Content.Client/Cargo/UI/BountyEntry.xaml.cs b/Content.Client/Cargo/UI/BountyEntry.xaml.cs index 027d7b3e8011..acc6aa365486 100644 --- a/Content.Client/Cargo/UI/BountyEntry.xaml.cs +++ b/Content.Client/Cargo/UI/BountyEntry.xaml.cs @@ -1,4 +1,5 @@ using Content.Client.Message; +using Content.Shared._NF.Bank; using Content.Shared.Cargo; using Content.Shared.Cargo.Prototypes; using Content.Shared.Random; @@ -40,7 +41,7 @@ public BountyEntry(CargoBountyData bounty, TimeSpan untilNextSkip) ("item", Loc.GetString(entry.Name)))); } ManifestLabel.SetMarkup(Loc.GetString("bounty-console-manifest-label", ("item", string.Join(", ", items)))); - RewardLabel.SetMarkup(Loc.GetString("bounty-console-reward-label", ("reward", bountyPrototype.Reward))); + RewardLabel.SetMarkup(Loc.GetString("bounty-console-reward-label", ("reward", BankSystemExtensions.ToSpesoString(bountyPrototype.Reward)))); // Frontier: bountyPrototype.Reward