Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFF console weirdness with antag POIs and shuttles #2732

Open
Tych0theSynth opened this issue Jan 19, 2025 · 1 comment
Open

IFF console weirdness with antag POIs and shuttles #2732

Tych0theSynth opened this issue Jan 19, 2025 · 1 comment
Labels
Bug Something isn't working

Comments

@Tych0theSynth
Copy link
Contributor

Description

I've noticed some issues with the IFF console functionality on LPB (POI IFF) and on shuttles which use the BaseVesselAntag proto.
The consoles default to showing the IFF/vessel outline as 'on' despite the prototype forcing it to off on spawn, this means that console doesn't actually change the state of the altered setting if you simply click the button and then close the UI.

If you leave the UI open and turn it from 'on' to 'off' and then back again, it functions fine.

Reproduction
Go to an antag POI and either buy an antag ship or use the POI IFF console.
Notice that the setting is set to 'on'.
Turn the setting 'off' and then close the UI. Open the UI again and it'll now be 'on' again.
Ghost and open the radar, notice that nothing has changed.

Open the IFF computer UI again.
Turn the setting 'off' and WITHOUT CLOSING THE UI, turn it back 'on'.
Ghost and open the radar. The POI outline or shuttle IFF will now be showing.

Additional context
This can also be solved by resetting the computer itself by un-anchoring and re-anchoring it. This forces it to inherit the grid's state.
Obviously this workaround doesn't work on the POI, as those consoles cannot be un-anchored.

@dvir001
Copy link
Contributor

dvir001 commented Jan 19, 2025

Oh, I think its an oversight on my part, the IFF get set on the POI via the comp to grid on spawn, but IFF computers don't update back.

Probably can be fixed by forcing the IFF computer to run a scan on the grid to find the real IFF status when you open it.

@whatston3 whatston3 added Bug Something isn't working and removed S: Untriaged labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants