Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature stamp needs its own entity #327

Closed
Cheackraze opened this issue Sep 17, 2023 · 4 comments
Closed

Signature stamp needs its own entity #327

Cheackraze opened this issue Sep 17, 2023 · 4 comments

Comments

@Cheackraze
Copy link
Member

Description

overriding an existing stamp makes no sense
Reproduction

Additional context

we should add the signature functionality to the PDA or something instead, so that anyone can sign papers and you don't have to use some strange object that doesn't make sense.

@dvir001
Copy link
Contributor

dvir001 commented Sep 18, 2023

It can be its own entity or use another entity, I made the code so it can be assigned to other stuff.
Do keep in mind that putting it on PDA or your card will need to have the code read from the card or PDA in your hand and not the one equipped, so a bit of a code change if we do this, nothing major. (You dont want it to read the user entity since it won't account for name changes or fake cards)

Also I find that using a PDA or Card to stamp is anti RP since its not a stamp, unlike an actual stamp.

On another note, the captain stamp had no actual use since captain means nothing when everyone are captain.
There is a PR to add the stamp to crates and SR vend machine to make it possible to buy it, also its coming in the captain locker if we remap it. #322

I also left the part of the code that add your rank to the stamp uncommented, it can say "Captain NAME" or "RANK NAME" instead of "NAME" but it might be super long.

@Cheackraze
Copy link
Member Author

I mean it's a signature right? Maybe making it a right click verb with just any pen? That isn't great either because it kind of hides the function. The thing is not everyone is captain all the time but imo there's no reason why anyone shouldn't be able to sign a paper

@dvir001
Copy link
Contributor

dvir001 commented Sep 18, 2023

I mean it's a signature right? Maybe making it a right click verb with just any pen? That isn't great either because it kind of hides the function. The thing is not everyone is captain all the time but imo there's no reason why anyone shouldn't be able to sign a paper

Ill try to think about some way to implement it on a more simple way, if we consider it signature ill also need to remove the "stamp" outline so it also adding up
image

In the main time I can remove the "captain" word from the stamp name to have it be more logical as a general use stamp

@dvir001
Copy link
Contributor

dvir001 commented Sep 24, 2023

Fixed and done with #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants