New Guns and Mosin Rework and Sawn PKA fix #1143

VividPups · 2024-03-22T21:48:40Z

About the PR

adds the SVT40
add the Valentine
add the Space Cleaner grenade
add the M34 'Willie Pete' grenade (Kes request)
add chicken nugget recipe
Rework the Mosin to allow Melee now

Why / Balance

Well, there aren't a lot of End shift Legal weapons, this PR adds a point between The Mosin and the AK with the new SVT40 rifle also added another pistol to be put inside the loot pool for gunships (SVT could be in T3)
As of now, I have added them to the less lethal Vending machine, and Liberation. Until the Loot spawn.yml is approve in the Research Bunker PR

Technical details

Also, Clean up some of the Files for Texures and Weapons to be in there Respective parts

Media

I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

again just some File cleaning in the Weapons area

Changelog

tweak: New sharpened Bayonets had outfitted the Mosins now
add: SVT40 and Valentine
add: Space Cleaner Grenade and M34 Willie Pete Grenade
add: Chicken nuggets now have a cooking recipe.

…n-14

github-actions · 2024-03-22T21:49:13Z

RSI Diff Bot; head commit bb192da merging into 69a12c7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Ammunition/svt40.rsi

State	Old	New	Status
base			Added
mag-1			Added
practice			Added
red			Added
rubber			Added
uranium			Added

Resources/Textures/_NF/Objects/Weapons/Guns/Pistols/Valentine.rsi

State	Old	New	Status
base			Added
bolt-open			Added
equipped-BELT			Added
icon			Added
inhand-left			Added
inhand-right			Added
mag-0			Added

Resources/Textures/_NF/Objects/Weapons/Guns/Rifles/svt40.rsi

State	Old	New	Status
base			Added
bolt-open			Added
equipped-BACKPACK			Added
icon			Added
inhand-left			Added
inhand-right			Added
mag-0			Added

Resources/Textures/_NF/Objects/Weapons/M34.rsi

State	Old	New	Status
icon			Added
primed			Added

Edit: diff updated after bb192da

VividPups · 2024-03-22T21:49:26Z

Yes, I know about the File with the Revolver ( I will fix it) and Spawner file (I will learn how to remove it)

VividPups · 2024-03-22T22:44:45Z

Im not sure what the problem is with the Sprites. They are just fine in-game for me

…change the meta.json to the right one

VividPups · 2024-03-23T03:48:12Z

Fix, the One for the gun, im going to need another set of eyes for this other error I'm getting, because I'm not seeing why it is saying that

TsjipTsjip

Most item descriptions have language mistakes in them. I've gone through and suggested changes for all of those which were directly apparent.

Your CL could be shortened into four entries, one for the mosin, one for the two new guns ("New guns: The SVT140 and Valentine pistol"), one for the two new grenades (see before) and one for the nugget recipe. I'd also reword this last one to not be roleplay-style: "Chicken nuggets now have a cooking recipe."

Lastly, and end-of-comment marker (-->) has snuck in below your CL entries.

Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/snipers.yml

Resources/Prototypes/_NF/Entities/Objects/Weapons/Ammunition/explosives.yml

Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/pistols.yml

Resources/Prototypes/_NF/Entities/Objects/Weapons/Ammunition/explosives.yml

Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/pistols.yml

Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/snipers.yml

…into Gun

VividPups · 2024-03-24T15:48:26Z

@TsjipTsjip @GreaseMonk , I think I made all the changes.

GreaseMonk · 2024-03-24T19:33:11Z

It makes no sense to add guns and then also add a cooking recipe, in the same PR, so split them up please, you could even make 3, so people can decide to add guns and food, but not the grenade.

Got some more points of concern here:

Please don't add napalm grenades to the gun vend that you can mass buy
Where did you get sprites from? If i can personally insert my opinion here, Im not super fond of the sprites and i cant put my finger on it to tell you what it is but its different
"Kesco and Sam's Weaponary Emporium" i think i read that KesCo is a company ingame, and there are posters referring to people, but there is a ship rule as well that you cant put your name on everything. Not my decision though
Remove # For you Slips, theyre bad comments

Please please make sure the guns are balanced, so it is ready for people to test and its not immediately overkill

VividPups · 2024-03-24T20:14:32Z

It makes no sense to add guns and then also add a cooking recipe, in the same PR, so split them up please, you could even make 3, so people can decide to add guns and food, but not the grenade.

Got some more points of concern here:

Please don't add napalm grenades to the gun vend that you can mass buy

Where did you get sprites from? If i can personally insert my opinion here, Im not super fond of the sprites and i cant put my finger on it to tell you what it is but its different

"Kesco and Sam's Weaponary Emporium" i think i read that KesCo is a company ingame, and there are posters referring to people, but there is a ship rule as well that you cant put your name on everything. Not my decision though

Remove # For you Slips, theyre bad comments

Please please make sure the guns are balanced, so it is ready for people to test and its not immediately overkill

-If I would to split up them in others PR I can 100% guarantee that something on my visual studios will break and it will take even more time to fix. I don't recall Dirv talking to me about the PR at all.

where do you want the napalm grenades than, I originally wanted it in a Loot spawner. It's almost been months and a half now since a Maintainer message me about it.
Sam's weaponry emporium is the full name of the company. (Same how Kesco, has her name on it)
the napalm and space cleaner has the same Form of the Tear gas grenade.

I Tested the weapons to what I thought was fair. I suggest everytime I add a weapon or a event for the maintainers to test it

GrandKadoer · 2024-03-25T02:03:20Z

"No NFSD won't get warcrime grenades" but then they're in a vendor? These are class 3 contraband, and should probably be on expeds.

TsjipTsjip

Some other minor things on the updated version. Nearly good tho.

Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/pistols.yml

Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/snipers.yml

dvir001 · 2024-03-25T10:51:53Z

space-wizards/space-station-14#25444

Omit cleaner.

dvir001 · 2024-03-25T10:53:29Z

Also your mosins made my build crash none stop when trying to use them now. (Build mod, not debug)

VividPups · 2024-03-25T13:41:59Z

Also your mosins made my build crash none stop when trying to use them now. (Build mod, not debug)

you know more Info then it crashes would help, Espically since I don't have "Build" and the Video is showing us to use Release

GreaseMonk · 2024-03-25T18:39:33Z

Also your mosins made my build crash none stop when trying to use them now. (Build mod, not debug)

you know more Info then it crashes would help, Espically since I don't have "Build" and the Video is showing us to use Release

It crashes when a mosin is handed out of a vending machine on frontier i think

VividPups · 2024-03-26T15:07:34Z

Also your mosins made my build crash none stop when trying to use them now. (Build mod, not debug)

you know more Info then it crashes would help, Espically since I don't have "Build" and the Video is showing us to use Release

It crashes when a mosin is handed out of a vending machine on frontier i think

I tested it on both vending machines that has it and spawn new ones. In and it isn't crashing or showing any errors for me. I put screen shots on the development chat

VividPups · 2024-03-29T17:45:20Z

I'm going to re-PR this at a later date. I however will not close until the new on is up. I will be putting the Mosin by itself, the SVT and Valentine together, and the Grenades In a different on. This will happen, After My Bluespace event is merge

VividPups added 3 commits February 11, 2024 13:03

Is It fix??

c04178b

Merge branch 'master' of https://github.com/VividPups/frontier-statio…

936fafb

…n-14

New GUNS !

06df043

github-actions bot added No C# Sprites YML labels Mar 22, 2024

VividPups added 4 commits March 22, 2024 16:54

Sprite fixs for Revolver and hopefully the SVT

e8cf670

Fix this

5e060a4

fix svt hiopefully

2a30bf9

Changes spawners back to default where it is just Arcadia stuff

23bdbf9

VividPups added 3 commits March 22, 2024 17:50

Add # Text to the files

16b2080

More balancing, lowing Amount of ammo use in the mosin by 5 and also …

adc5a35

…change the meta.json to the right one

FIX THIS TIME??????????

5c49e91

VividPups added 3 commits March 22, 2024 22:50

fix now?

8516efa

updates and fixs

9dd2b35

the FIX for the Sawn PKA

fbd2fcc

VividPups changed the title ~~New Guns and Mosin Rework~~ New Guns and Mosin Rework and Sawn PKA fix Mar 23, 2024

TsjipTsjip suggested changes Mar 24, 2024

View reviewed changes

GreaseMonk added the Status: Awaiting Changes This PR has changes that need to be made before merging label Mar 24, 2024

VividPups and others added 7 commits March 24, 2024 09:26

Update snipers.yml

773ace6

Update explosives.yml

cb35423

Not post to be in this PR

4b189a7

Merge branch 'Gun' of https://github.com/VividPups/frontier-station-14 …

6eeae7c

…into Gun

Update pistols.yml

953642c

Update snipers.yml

c66434e

Update snipers.yml

7ee9f86

VividPups added 5 commits March 24, 2024 10:14

Update lesslethalvend.yml

fd09aaa

Update snipers.yml

a9cad04

Update explosives.yml

8b026ad

Update pistols.yml

f19c8c2

Update lesslethalvend.yml

70e699c

TsjipTsjip suggested changes Mar 25, 2024

View reviewed changes

VividPups and others added 4 commits March 25, 2024 08:46

Update pistols.yml

05f789a

Update snipers.yml

b355034

remove slips nade

5452d84

Update janidrobe.yml

f659757

Merge branch 'new-frontiers-14:master' into Gun

0bf1efa

dvir001 added the Status: Need Discussion label Mar 28, 2024

Merge branch 'new-frontiers-14:master' into Gun

0395a05

Merge branch 'new-frontiers-14:master' into Gun

bb192da

VividPups closed this May 6, 2024

VividPups deleted the Gun branch May 9, 2024 22:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Guns and Mosin Rework and Sawn PKA fix #1143

New Guns and Mosin Rework and Sawn PKA fix #1143

VividPups commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

VividPups commented Mar 22, 2024

VividPups commented Mar 22, 2024

VividPups commented Mar 23, 2024

TsjipTsjip left a comment •

edited

Loading

VividPups commented Mar 24, 2024

GreaseMonk commented Mar 24, 2024 •

edited

Loading

VividPups commented Mar 24, 2024

GrandKadoer commented Mar 25, 2024

TsjipTsjip left a comment

dvir001 commented Mar 25, 2024

dvir001 commented Mar 25, 2024

VividPups commented Mar 25, 2024

GreaseMonk commented Mar 25, 2024

VividPups commented Mar 26, 2024

VividPups commented Mar 29, 2024 •

edited

Loading

New Guns and Mosin Rework and Sawn PKA fix #1143

New Guns and Mosin Rework and Sawn PKA fix #1143

Conversation

VividPups commented Mar 22, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Breaking changes

github-actions bot commented Mar 22, 2024 • edited Loading

VividPups commented Mar 22, 2024

VividPups commented Mar 22, 2024

VividPups commented Mar 23, 2024

TsjipTsjip left a comment • edited Loading

Choose a reason for hiding this comment

VividPups commented Mar 24, 2024

GreaseMonk commented Mar 24, 2024 • edited Loading

VividPups commented Mar 24, 2024

GrandKadoer commented Mar 25, 2024

TsjipTsjip left a comment

Choose a reason for hiding this comment

dvir001 commented Mar 25, 2024

dvir001 commented Mar 25, 2024

VividPups commented Mar 25, 2024

GreaseMonk commented Mar 25, 2024

VividPups commented Mar 26, 2024

VividPups commented Mar 29, 2024 • edited Loading

VividPups commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

TsjipTsjip left a comment •

edited

Loading

GreaseMonk commented Mar 24, 2024 •

edited

Loading

VividPups commented Mar 29, 2024 •

edited

Loading