Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dungeon Fix #193

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Dungeon Fix #193

merged 4 commits into from
Aug 13, 2023

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Aug 12, 2023

About the PR

Xeno queen and dragon will get removed if they try to leave the planet they live on.

Tested this isn't breaking the rewards.
If it died before the end it will complete as normal
If it was left on the planet the expo will not be completed
If it was left on the planet and you called to leave before timer ended the expo will not be completed
If it was left on your ship alive expo will not be completed

This PR also fix 2 missing crate rewards that where no longer in the game.

I will try to add some rare dragon egg later to allow spawn of a mini dragon.

@dvir001 dvir001 changed the title Space dragon Dungeon Fix Aug 12, 2023
@Cheackraze
Copy link
Member

i want this so bad but the yml linter cries... somethings wrong in your prototype

@dvir001
Copy link
Contributor Author

dvir001 commented Aug 13, 2023

i want this so bad but the yml linter cries... somethings wrong in your prototype

Fixed

@Cheackraze
Copy link
Member

i want this so bad but the yml linter cries... somethings wrong in your prototype

Fixed

bless

@Cheackraze Cheackraze merged commit 8ed6532 into new-frontiers-14:master Aug 13, 2023
10 of 11 checks passed
@dvir001 dvir001 deleted the Space-Dragon branch August 19, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants