Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better dock signage #2040

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Better dock signage #2040

merged 6 commits into from
Sep 21, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

Adds two posters, one saying "DOCK" and one saying "BUS" that replace the existing "EVAC" signs.

Removes some delays from static directional signs.

Why / Balance

Looks better.

How to test

  1. Spawn, warp to Frontier, Trade Outpost, buy a few ships, check that the signs make sense.

Media

Dock sign.
image

Bus sign.
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Dock and bus signs should be correct now instead of appearing as "EVAC" signs.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle Map-POI Map - POI No C# Sprites Map-Outpost Map - Outpost labels Sep 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 21, 2024 •
edited
Loading

RSI Diff Bot; head commit 194d763 merging into 1dda632
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Wallmounts/signs.rsi

State Old New Status
bus Added
dock Added

Edit: diff updated after 194d763

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 21, 2024
@dvir001 dvir001 self-requested a review September 21, 2024 21:30
@dvir001 dvir001 merged commit 7d28a94 into new-frontiers-14:master Sep 21, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Sep 21, 2024
@FrontierATC
Automatic Changelog (#2040)
ddfcd76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvir001 dvir001 dvir001 approved these changes

@MagnusCrowe MagnusCrowe Awaiting requested review from MagnusCrowe

Assignees
No one assigned
Labels
Map-Outpost Map - Outpost Map-POI Map - POI Map-Shuttle Map - Shuttle No C# Sprites Status: Needs Review This PR is awaiting reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whatston3 @dvir001