Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gruntfile suggestion #12

Open
rodabt opened this issue Oct 22, 2016 · 1 comment
Open

Gruntfile suggestion #12

rodabt opened this issue Oct 22, 2016 · 1 comment

Comments

@rodabt
Copy link

rodabt commented Oct 22, 2016

Hi,

First of all, great generator. It's very simple and effective.

I started a simple project including angular-plotly library which depends on plotly. Using bower install angular-plotly --save works ok and grunt dev works as expected. However if I do a grunt build it fails with the following error:

Running "concat:build" (concat) task
Warning: Unable to read "app/assets/libs/plotly.js" file (Error code: EISDIR). Used --force, continuing.

The concat task was failing because it treated "plotly.js" as a file a not a folder the correction is easy, just add filter: 'isFile' to Gruntfile.js:

            build: {
                src: [
                    // Angular Project Dependencies,
                    'app/assets/libs/angular/angular.js',
                    'app/assets/libs/{,**/}*.js'
                ],
                filter: 'isFile',
                dest: 'app/assets/js/<%= pkg.name %>-angularbundle.js'
            }

In the future I suggest it should be included by default in the generator.

@newaeonweb
Copy link
Owner

@rodabt Thanks for the comment. I'm planning a new version with some bug fixes and i'll include the tip. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants