Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of pure bismuth contamination's tests #190

Closed
5 tasks done
prisma34 opened this issue Jul 18, 2024 · 1 comment
Closed
5 tasks done

Implementation of pure bismuth contamination's tests #190

prisma34 opened this issue Jul 18, 2024 · 1 comment
Assignees
@prisma34
Labels
enhancement New feature or request
Milestone
Release of v3.0.0

Comments

@prisma34
Copy link
Collaborator

prisma34 commented Jul 18, 2024 •
edited by lelaus
Loading

Implement tests for initialization and boundary values verification for contaminating compounds in pure bismuth.
It involves the implementation of the BismuthContaminationTester class, with:

  • the test_init_fromX method in test_bismuth_fromX_spanT.
  • the test_min method in test_lbh15_bounds.py.
  • the test_max method in test_lbh15_bounds.py.
  • the test_T_at_min method in test_lbh15_bounds.py.
  • the test_T_at_max method in test_lbh15_bounds.py.

This issue is handled as one of the tasks of issue #188.
@lelaus lelaus added the enhancement New feature or request label Jul 18, 2024
@lelaus lelaus added this to the Release of v3.0.0 milestone Jul 18, 2024
prisma34 pushed a commit that referenced this issue Jul 22, 2024
[189_contamination_tests], issue #190, Implement tests for initializa…
e8b77ab 
…tion and boundary values verification for contaminating compounds in pure bismuth.
@lelaus lelaus mentioned this issue Jul 30, 2024
Closed
2 tasks
prisma34 pushed a commit that referenced this issue Aug 27, 2024
[190_contamination_tests_bismuth], issue #190, Implementation in test…
5938976 
…_bismuth_fromX_spanT of BismuthContaminationTester method. New implementations in _lbh15.py and test_bismuth_fromX_spanT to handle the case of constant correlations. Implementation of guess_helper for cp in bismuth_properties.py. guess_helper method introduced also in interface.py.
prisma34 pushed a commit that referenced this issue Aug 27, 2024
[190_contamination_tests_bismuth], issue #190, Implementation of gues…
aa3fdca 
…s_helper in cp_sobolev2011 and cp_gurvich1991 accordingly to the changes made in _lbh15.py, as it was made in branch 189.
prisma34 pushed a commit that referenced this issue Aug 28, 2024
[190_contamination_tests_bismuth], issue #190, Addition of property_v…
106df06 
…alue as an additional entry of guess_helper method for coherence with the changes made on the issue 191. Implementation in _lbh15.py, lead_properties.py and bismuth_properties.py accordingly to this change.
prisma34 pushed a commit that referenced this issue Aug 29, 2024
[190_contamination_tests_bismuth], issue #190, Merged branch 189_cont…
c0c7071 
…amination_tests.
prisma34 pushed a commit that referenced this issue Aug 29, 2024
[190_contamination_tests_bismuth], issue #190, Addition of the is_con…
abc4870 
…stant() method in bismuth_contamination.py. Adaptation of test_bismuth_fromX_spanT.py accordingly.
@prisma34 prisma34 mentioned this issue Aug 29, 2024
Merged
@lelaus
Copy link
Collaborator

lelaus commented Aug 29, 2024

The first task of this issue has been managed. Since constant properties are added, the method is_constant() has been added to the class PropertyInterface by merging branch 189_contamination_tests.

No need to change the doc.
Tests for bismuth contaminant properties have been added.

@lelaus lelaus closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prisma34 prisma34

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release of v3.0.0
Development

No branches or pull requests
2 participants
@prisma34 @lelaus