Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move site preview section out of Ecommerce module. #283

Open
aratidgr8 opened this issue Apr 15, 2024 · 2 comments
Open

Move site preview section out of Ecommerce module. #283

aratidgr8 opened this issue Apr 15, 2024 · 2 comments

Comments

@aratidgr8
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently on Home page of brand plugin we display

  • Live site preview for both, live and coming soon mode for WordPress.
  • On mouse over of site preview section we display view site & edit site CTAs

This section is implemented in src/components/OnboardingScreen.js component in Ecommerce Module.

As per module responsibilities guidelines this section should not be a primary concern of wp-module-ecommerce and needs to be handled separately.

Screenshot 2024-04-15 at 5 11 14 PM

Describe the solution you'd like
Move this functionality out of Ecommerce module.

Describe alternatives you've considered

Additional context

@aratidgr8
Copy link
Contributor Author

@wpscholar Please confirm if site preview section should be a separate module itself or it should be moved to any of existing newfold-labs modules like wp-module-coming-soon etc.

@aratidgr8 aratidgr8 mentioned this issue Apr 15, 2024
8 tasks
@wpscholar
Copy link
Member

@aratidgr8 I think it probably makes sense to have a wp-module-homepage module that handles anything specific to the homepage. We'd use slot-fill to ensure that the Coming Soon module can handle the site/store launch, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants