Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react console warnings for Home page #364

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

aratidgr8
Copy link
Contributor

@aratidgr8 aratidgr8 commented Oct 16, 2024

Proposed changes

  • Fix for React warnings in console when solution nudge added on Homepage Dashboard
  • Updated basename & download value for plugins
  • Removed storageKey
  • Updated data attributes as discussed with @arunshenoy99

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpscholar wpscholar merged commit 270f9d5 into solutions Oct 16, 2024
2 checks passed
@wpscholar wpscholar deleted the fix/react-warnings-fix-for-homepage branch October 16, 2024 16:28
@wpscholar wpscholar restored the fix/react-warnings-fix-for-homepage branch October 16, 2024 16:28
@wpscholar wpscholar deleted the fix/react-warnings-fix-for-homepage branch October 16, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants