Update/ecommerce release bump 1.3.35 #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #3989 ↗︎
Details:
Review all test suite changes for PR #598 ↗︎ |
|||||||||||||||
Passing run #3988 ↗︎
Details:
Review all test suite changes for PR #598 ↗︎ |
|||||||||||||||
* develop: update i18n command to remove old json files and run i18n. update marketplace to 2.3.1 bump marketplace module to 2.3.0 composer run i18n use appId and pluginId in tests add product page integration Bump version Modify deps coming soon fixes # Conflicts: # composer.json # composer.lock # package-lock.json # package.json
|
I updated this with latest from dev - it included an update to the marketplace module to fix those broken tests. If tests pass, I'll update this to "ready for review" |
|
With passing tests, this should be good, but it would be best to wait for the an e-commerce release which fixes the issue that required an out-of-cycle release today to roll back the e-commerce module to 1.3.31 in 2.9.3. I don't see a point to merging broken code into the dev branch that will need updating before a release anyway. |
… 26th June for Store page
aratidgr8
changed the title
wpscholar
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Bug Fix:
Tech Debt:
Github issue #331 : Updated the DB variable name from
showMigrationSteptonfd_show_migration_stepas per NewFold coding standards.Cypress tests improvised - Implemented the
testIsolationflag so each test is expected to be more independent, and combined tests that were not independent to run in the same itFeature Requests:
PRESS0-631 | Dismiss woo notice
Type of Change
Checklist
Further comments