fixes

newrelic · Feb 11, 2025 · 262157c · 262157c
1 parent b72039f
commit 262157c
Showing 1 changed file with 5 additions and 43 deletions.
diff --git a/.github/workflows/run-e2e-tests.yaml b/.github/workflows/run-e2e-tests.yaml
@@ -1,13 +1,11 @@
 name: E2E Test Workflow
 
 on:
-  pull_request_review:
-    types:
-      - submitted
+  pull_request:
+    -develop
 
 jobs:
   build-templates:
-    if: github.event.review.state == 'approved'
     runs-on: ubuntu-latest
     permissions:
       id-token: write
@@ -47,15 +45,6 @@ jobs:
           name: ${{ matrix.TEMPLATE_FILE }}.yaml
           path: .aws-sam/build/${{ matrix.TEMPLATE_FILE }}/${{ matrix.TEMPLATE_FILE }}.yaml
 
-      - name: Send failure notification to Slack
-        if: always()
-        uses: ravsamhq/notify-slack-action@v1
-        with:
-          status: ${{ job.status }}
-          notify_when: 'failure'
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-
   run-e2e-tests-cloudwatch:
     needs: [build-templates]
     runs-on: ubuntu-latest
@@ -72,7 +61,7 @@ jobs:
       - name: Download Artifact
         uses: actions/download-artifact@v4
         with:
-          path: build-artifact
+          path: build-artifacts
 
       - name: Setup Go
         uses: actions/setup-go@v5
@@ -97,15 +86,6 @@ jobs:
           cd e2e-tests
           ./lambda-cloudwatch-trigger.sh ${{ matrix.test-case }}
 
-      - name: Send failure notification to Slack
-        if: always()
-        uses: ravsamhq/notify-slack-action@v1
-        with:
-          status: ${{ job.status }}
-          notify_when: 'failure'
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-
   run-e2e-tests-s3:
     needs: [build-templates]
     runs-on: ubuntu-latest
@@ -122,7 +102,7 @@ jobs:
       - name: Download Artifact
         uses: actions/download-artifact@v4
         with:
-          path: build-artifact
+          path: build-artifacts
 
       - name: Setup Go
         uses: actions/setup-go@v5
@@ -147,15 +127,6 @@ jobs:
           cd e2e-tests
           ./lambda-s3-trigger.sh ${{ matrix.test-case }}
 
-      - name: Send failure notification to Slack
-        if: always()
-        uses: ravsamhq/notify-slack-action@v1
-        with:
-          status: ${{ job.status }}
-          notify_when: 'failure'
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-
   clean-up:
     needs: [run-e2e-tests-cloudwatch, run-e2e-tests-s3]
     runs-on: ubuntu-latest
@@ -177,13 +148,4 @@ jobs:
         env:
           S3_BUCKET: unified-lambda-e2e-test-templates
         run:
-          aws s3 rm "s3://$S3_BUCKET" --recursive
-
-      - name: Send failure notification to Slack
-        if: always()
-        uses: ravsamhq/notify-slack-action@v1
-        with:
-          status: ${{ job.status }}
-          notify_when: 'failure'
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+          aws s3 rm "s3://$S3_BUCKET" --recursive