Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NR-347440] CFN template validate lambda integration logs #17

Merged
merged 44 commits into from
Feb 17, 2025

Conversation

ahegdeNR
Copy link
Contributor

@ahegdeNR ahegdeNR commented Jan 15, 2025

E2E tests compiled for s3 and cloudwatch cases:

  1. Create events in lambda from s3 and cloudwatch
  2. Validate that logs are getting populated in New Relic on event creation.
  3. Create scripts to fetch and validate logs in New Relic.
  4. Validate common attributes and entity synthesis attributes
  5. Modify workflow to run only when pr approval is given
  6. When tests fail, slack notification is sent to logging-integrations-eng

@ahegdeNR ahegdeNR self-assigned this Jan 15, 2025
@hrai-nr
Copy link
Contributor

hrai-nr commented Jan 22, 2025

  1. Test cases for entity synthesis params are missing.
  2. Please add the slack notification code.

@ahegdeNR ahegdeNR requested a review from hrai-nr January 29, 2025 08:56
Copy link
Contributor

@hrai-nr hrai-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are looking fine, but code to send notification to slack channel is missing, please add that.

Copy link
Contributor

@maya-jha maya-jha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo to team.

@ahegdeNR
Copy link
Contributor Author

  1. Test cases for entity synthesis params are missing.
  2. Please add the slack notification code.

Completed

@ahegdeNR
Copy link
Contributor Author

@maya-jha addressed all comments and made the requested changes

@ahegdeNR ahegdeNR requested review from maya-jha and hrai-nr February 11, 2025 02:05
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Download Artifact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try deploying using s3 reference instead of downloading it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried sam deploy -h command and checked the usage, --s3-bucket option is used to upload artifacts rather than referencing the file. So I think there's no other direct way that uploading and getting build templates to different jobs

voorepreethi
voorepreethi previously approved these changes Feb 11, 2025
@ahegdeNR ahegdeNR merged commit 2b48523 into develop Feb 17, 2025
22 checks passed
@ahegdeNR ahegdeNR deleted the NR-347440-e2e-event-creation branch February 17, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants