Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add wdio test for trace with replay behavior #607

Merged
merged 15 commits into from
Jul 28, 2023
Merged

chore: Add wdio test for trace with replay behavior #607

merged 15 commits into from
Jul 28, 2023

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Jun 28, 2023

Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.

Overview

Follow up automated testing to #545 and #583 .

Related Issue(s)

NR-139661

Testing

Negligible src code change. Double check the wdio tests added.

@cwli24 cwli24 marked this pull request as ready for review June 30, 2023 00:07
@cwli24 cwli24 added the MMF Work directly planned for in an MMF label Jun 30, 2023
@cwli24
Copy link
Contributor Author

cwli24 commented Jun 30, 2023 •
edited
Loading

jil tests: https://github.com/newrelic/newrelic-browser-agent/actions/runs/5417909691

@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Static Badge

Last ran on July 27, 2023 15:54:05 CDT
Checking merge of (f764b13) into main (3d9f2c0)

@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Asset Size Report

Merging this pull request will result in the following CDN asset size changes:

Asset Name Previous Size New Size Diff
nr-loader-spa.min 51.18 kB / 17.19 kB (gzip) 51.19 kB / 17.19 kB (gzip) +0.01% / +0.01% (gzip)
nr-loader-full.min 44.75 kB / 15.25 kB (gzip) 44.76 kB / 15.25 kB (gzip) +0.01% / +0.01% (gzip)
nr-loader-rum.min 27.98 kB / 9.97 kB (gzip) 27.99 kB / 9.98 kB (gzip) +0.02% / +0.03% (gzip)
nr-loader-spa-polyfills.min 124.77 kB / 39.6 kB (gzip) 124.78 kB / 39.6 kB (gzip) +0% / -0% (gzip)
nr-loader-full-polyfills.min 116.76 kB / 37.49 kB (gzip) 116.77 kB / 37.49 kB (gzip) +0.01% / -0% (gzip)
nr-loader-rum-polyfills.min 96.75 kB / 31.71 kB (gzip) 96.76 kB / 31.72 kB (gzip) +0.01% / +0% (gzip)
nr-loader-worker.min 41.31 kB / 13.97 kB (gzip) 41.32 kB / 13.98 kB (gzip) +0.01% / +0.01% (gzip)

Merging this pull request will result in the following NPM package consumer size changes:

Asset Name Previous Size New Size Diff
Browser Agent 51.32 kB / 17.09 kB (gzip) 51.32 kB / 17.09 kB (gzip) +0.01% / +0.01% (gzip)
Custom Lite Agent 28.13 kB / 9.91 kB (gzip) 28.14 kB / 9.91 kB (gzip) +0.02% / +0.03% (gzip)
Custom Pro Agent 44.8 kB / 15.08 kB (gzip) 44.81 kB / 15.08 kB (gzip) +0.01% / +0.02% (gzip)
Custom SPA Agent 51.2 kB / 17.05 kB (gzip) 51.21 kB / 17.05 kB (gzip) +0.01% / +0.01% (gzip)
Worker Agent 304.86 kB / 94.29 kB (gzip) 304.87 kB / 94.3 kB (gzip) +0.01% / +0.01% (gzip)
Other Standard CDN Assets

Released Assets

Asset Name Asset Size
recorder.643cfeda.min.js 166.33 kB / 52.44 kB (gzip)
spa-aggregate.495db083.min.js 20.96 kB / 7.45 kB (gzip)
page_view_timing-aggregate.d72a908a.min.js 14.99 kB / 5.44 kB (gzip)
860.8fec16f2.min.js 14.09 kB / 5.27 kB (gzip)
session_trace-aggregate.2137f2a6.min.js 12.24 kB / 4.53 kB (gzip)
page_view_event-aggregate.e765729e.min.js 11.12 kB / 4.19 kB (gzip)
jserrors-aggregate.f8100d3b.min.js 9.55 kB / 3.65 kB (gzip)
metrics-aggregate.0d982f48.min.js 8.56 kB / 2.93 kB (gzip)
646.a8872fbe.min.js 7.97 kB / 3.36 kB (gzip)
session_replay-aggregate.948ed12b.min.js 7.97 kB / 2.93 kB (gzip)
ajax-aggregate.629e6d59.min.js 7.19 kB / 3.1 kB (gzip)
compressor.772ac1fe.min.js 7.09 kB / 3.57 kB (gzip)
page_action-aggregate.636893b0.min.js 4.73 kB / 1.92 kB (gzip)
async-api.eaff3276.min.js 2.69 kB / 1.38 kB (gzip)
session-manager.22036a2b.min.js 1.47 kB / 742 B (gzip)
lazy-feature-loader.d2774909.min.js 1.17 kB / 498 B (gzip)

Built Assets

Asset Name Asset Size
recorder.643cfeda.min.js 166.33 kB / 52.44 kB (gzip)
spa-aggregate.495db083.min.js 20.96 kB / 7.45 kB (gzip)
page_view_timing-aggregate.d72a908a.min.js 14.99 kB / 5.44 kB (gzip)
860.8fec16f2.min.js 14.09 kB / 5.27 kB (gzip)
session_trace-aggregate.a490ad60.min.js 12.25 kB / 4.53 kB (gzip)
page_view_event-aggregate.e765729e.min.js 11.12 kB / 4.19 kB (gzip)
jserrors-aggregate.f8100d3b.min.js 9.55 kB / 3.65 kB (gzip)
metrics-aggregate.0d982f48.min.js 8.56 kB / 2.93 kB (gzip)
646.a8872fbe.min.js 7.97 kB / 3.36 kB (gzip)
session_replay-aggregate.948ed12b.min.js 7.97 kB / 2.93 kB (gzip)
ajax-aggregate.629e6d59.min.js 7.19 kB / 3.1 kB (gzip)
compressor.772ac1fe.min.js 7.09 kB / 3.57 kB (gzip)
page_action-aggregate.636893b0.min.js 4.73 kB / 1.92 kB (gzip)
async-api.eaff3276.min.js 2.69 kB / 1.38 kB (gzip)
session-manager.22036a2b.min.js 1.47 kB / 742 B (gzip)
lazy-feature-loader.d2774909.min.js 1.17 kB / 498 B (gzip)
Other Polyfill CDN Assets

Released Assets

Asset Name Asset Size
recorder.643cfeda-es5.min.js 167.03 kB / 52.48 kB (gzip)
nr-polyfills.min.js 52.26 kB / 18.01 kB (gzip)
session_trace-aggregate.c02f2a42-es5.min.js 32.26 kB / 8.5 kB (gzip)
compressor.5b9c7398-es5.min.js 30.02 kB / 11.29 kB (gzip)
session_replay-aggregate.6c0aba07-es5.min.js 19.27 kB / 6.54 kB (gzip)
page_view_timing-aggregate.3d86db09-es5.min.js 18.68 kB / 6.17 kB (gzip)
spa-aggregate.1f73f06f-es5.min.js 17.77 kB / 6.14 kB (gzip)
173.3788d9f7-es5.min.js 17.41 kB / 6.14 kB (gzip)
page_view_event-aggregate.e71662d2-es5.min.js 12.65 kB / 4.8 kB (gzip)
jserrors-aggregate.2883be04-es5.min.js 12.33 kB / 4.4 kB (gzip)
385.6d401e84-es5.min.js 10.47 kB / 4.18 kB (gzip)
metrics-aggregate.c4251142-es5.min.js 9.91 kB / 3.35 kB (gzip)
945.d2c7843e-es5.min.js 7.51 kB / 2.72 kB (gzip)
page_action-aggregate.087bc19b-es5.min.js 7.33 kB / 2.64 kB (gzip)
ajax-aggregate.d44e21ef-es5.min.js 4.35 kB / 2.07 kB (gzip)
async-api.bb0e3099-es5.min.js 3.84 kB / 1.89 kB (gzip)
session-manager.618cfdd6-es5.min.js 1.7 kB / 783 B (gzip)
lazy-feature-loader.c4f55624-es5.min.js 1.22 kB / 514 B (gzip)

Built Assets

Asset Name Asset Size
recorder.643cfeda-es5.min.js 167.03 kB / 52.48 kB (gzip)
nr-polyfills.min.js 52.26 kB / 18.01 kB (gzip)
session_trace-aggregate.55fac0dd-es5.min.js 32.27 kB / 8.5 kB (gzip)
compressor.5b9c7398-es5.min.js 30.02 kB / 11.29 kB (gzip)
session_replay-aggregate.6c0aba07-es5.min.js 19.27 kB / 6.54 kB (gzip)
page_view_timing-aggregate.3d86db09-es5.min.js 18.68 kB / 6.17 kB (gzip)
spa-aggregate.1f73f06f-es5.min.js 17.77 kB / 6.14 kB (gzip)
173.3788d9f7-es5.min.js 17.41 kB / 6.14 kB (gzip)
page_view_event-aggregate.e71662d2-es5.min.js 12.65 kB / 4.8 kB (gzip)
jserrors-aggregate.2883be04-es5.min.js 12.33 kB / 4.4 kB (gzip)
385.6d401e84-es5.min.js 10.47 kB / 4.18 kB (gzip)
metrics-aggregate.c4251142-es5.min.js 9.91 kB / 3.35 kB (gzip)
945.d2c7843e-es5.min.js 7.51 kB / 2.72 kB (gzip)
page_action-aggregate.087bc19b-es5.min.js 7.33 kB / 2.64 kB (gzip)
ajax-aggregate.d44e21ef-es5.min.js 4.35 kB / 2.07 kB (gzip)
async-api.bb0e3099-es5.min.js 3.84 kB / 1.89 kB (gzip)
session-manager.618cfdd6-es5.min.js 1.7 kB / 783 B (gzip)
lazy-feature-loader.c4f55624-es5.min.js 1.22 kB / 514 B (gzip)

@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #607 (f764b13) into main (3d9f2c0) will increase coverage by 1.38%.
Report is 4 commits behind head on main.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   66.64%   68.02%   +1.38%     
==========================================
  Files         130      130              
  Lines        6011     6011              
  Branches     1141     1165      +24     
==========================================
+ Hits         4006     4089      +83     
+ Misses       1641     1579      -62     
+ Partials      364      343      -21
Flag Coverage Δ
integration-tests 83.35% <100.00%> (+1.36%) ⬆️
jest-component 21.17% <0.00%> (+0.01%) ⬆️
jest-unit 23.16% <25.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/features/session_trace/aggregate/index.js 53.11% <66.66%> (+4.86%) ⬆️
src/features/utils/instrument-base.js 94.73% <100.00%> (+0.09%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

metal-messiah
metal-messiah approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@metal-messiah metal-messiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with validation of comment that test is still good

metal-messiah
metal-messiah previously requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@metal-messiah metal-messiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get test suite passing, then g2g

@metal-messiah metal-messiah added the needs follow up Issue needs follow-up to ensure the problem has been solved by a release, PR, or otherwise. label Jul 27, 2023
@metal-messiah
Copy link
Member

https://github.com/newrelic/newrelic-browser-agent/actions/runs/5684537511

@patrickhousley patrickhousley dismissed metal-messiah’s stale review July 28, 2023 00:03

Jordan fixed the tests.

@patrickhousley patrickhousley merged commit 1c2f9be into main Jul 28, 2023
46 checks passed
@patrickhousley patrickhousley deleted the trace-wdio branch July 28, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhousley patrickhousley patrickhousley approved these changes

@metal-messiah metal-messiah Awaiting requested review from metal-messiah

Assignees
No one assigned
Labels
MMF Work directly planned for in an MMF needs follow up Issue needs follow-up to ensure the problem has been solved by a release, PR, or otherwise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwli24 @metal-messiah @patrickhousley