Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Log messages are formatted even when audit log is disabled #1733

Closed
tippmar-nr opened this issue Jun 21, 2023 · 1 comment
Closed

Audit Log messages are formatted even when audit log is disabled #1733

tippmar-nr opened this issue Jun 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@tippmar-nr
Copy link
Member

Description
After the migration to use Serilog for internal logging, we rely on configuration to suppress output of audit log messages. But it turns out that the code that formats and emits the message to Serilog still executes on every data send, resulting in unnecessary processing and memory allocation.

Expected Behavior
Do not format and emit audit log messages except when audit logging is enabled.

For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5):
P4
Suggested T-Shirt size (S, M, L, XL, Unknown):
S

@tippmar-nr tippmar-nr added the bug Something isn't working label Jun 21, 2023
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant