From 4e26f7489ea8a6c6c7f71384edb443a7a038249f Mon Sep 17 00:00:00 2001 From: Hannah Ramadan Date: Tue, 13 Feb 2024 13:29:35 -0800 Subject: [PATCH] Remove tests that look for a txn in error collector --- .../ruby_openai_instrumentation_test.rb | 33 ------------------- 1 file changed, 33 deletions(-) diff --git a/test/multiverse/suites/ruby_openai/ruby_openai_instrumentation_test.rb b/test/multiverse/suites/ruby_openai/ruby_openai_instrumentation_test.rb index eae14180ec..5b1b5d4e37 100644 --- a/test/multiverse/suites/ruby_openai/ruby_openai_instrumentation_test.rb +++ b/test/multiverse/suites/ruby_openai/ruby_openai_instrumentation_test.rb @@ -130,17 +130,6 @@ def test_set_llm_agent_attribute_on_chat_transaction assert_truthy harvest_transaction_events![1][0][2][:llm] end - def test_set_llm_agent_attribute_on_chat_error_transaction - in_transaction do |txn| - stub_post_request do - client.chat(parameters: chat_params) - NewRelic::Agent.notice_error(StandardError.new) - end - end - - assert_truthy harvest_error_events![1][0][2][:llm] - end - def test_conversation_id_added_to_summary_events conversation_id = '12345' in_transaction do @@ -241,26 +230,4 @@ def test_set_llm_agent_attribute_on_embedding_transaction assert_truthy harvest_transaction_events![1][0][2][:llm] end - - def test_set_llm_agent_attribute_on_embedding_error_transaction - in_transaction do |txn| - stub_post_request do - client.embeddings(parameters: embeddings_params) - NewRelic::Agent.notice_error(StandardError.new) - end - end - - assert_truthy harvest_error_events![1][0][2][:llm] - end - - def test_missing_parameters - in_transaction do |txn| - stub_error_post_request do - client.embeddings(parameters: missing_embeddings_param) - NewRelic::Agent.notice_error(StandardError.new) - end - end - - assert_truthy harvest_error_events![1][0][2][:llm] - end end