Add Elasticsearch version constraint #2346
Labels
1
Story Point Estimate
good first issue
jul-sep qtr
Represents proposed work item for the Jul-Sep quarter
needs review
The Ruby agent currently offers support for Elasticsearch v7+, but attempts to instrument all versions since instrumentation may work with earlier versions.
Our test suite fails on verions < v7, the issue seems related to Elasticsearch::API::Actions#explain. While our instrumentation may work with earlier versions, let's skip instrumenting since Elasticsearch EOL'd v5 and v6 and we don't offer official support.
A possible solution & refactor includes creating a new variable to hold the Elasticsearch version, adding a version
depends on
, and switching the order of the instrumentation check (since over time more versions will be greater than 8.0.0):lib/new_relic/agent/instrumentation/elasticsearch.rb
The text was updated successfully, but these errors were encountered: