Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Ruby/Thread + other spans #2371

Closed
tannalynn opened this issue Dec 18, 2023 · 1 comment · Fixed by #2389
Closed

Remove the Ruby/Thread + other spans #2371

tannalynn opened this issue Dec 18, 2023 · 1 comment · Fixed by #2389
Labels
enhancement Enhancement to existing features jan-mar qtr Possible FY Q4 candidate

Comments

@tannalynn
Copy link
Contributor

tannalynn commented Dec 18, 2023 •
edited
Loading

While our thread instrumentation has allowed customers to have visibility into the work happening inside of the threads, the actual spans created by the thread instrumentation seem to cause confusion frequently.
We should update the agent to no longer create the spans for 'Ruby/Thread', 'Ruby/Fiber', and perhaps for the concurrent-ruby instrumentation as well. This change will NOT impact the agents ability to record instrumented code that is run inside of these threads, this will only prevent the specified spans from being created.
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-199037

@kaylareopelle kaylareopelle added version: 10.0.0 Next Major Release - Breaking Changes jan-mar qtr Possible FY Q4 candidate enhancement Enhancement to existing features labels Dec 18, 2023
@kford-newrelic kford-newrelic added jan-mar qtr Possible FY Q4 candidate and removed jan-mar qtr Possible FY Q4 candidate labels Dec 20, 2023
@tannalynn tannalynn removed the version: 10.0.0 Next Major Release - Breaking Changes label Jan 5, 2024
@tannalynn tannalynn mentioned this issue Jan 5, 2024
Merged
@tannalynn tannalynn moved this from Triage to In progress in Ruby Engineering Board Jan 8, 2024
@github-project-automation github-project-automation bot moved this from In progress to Code Complete/Done in Ruby Engineering Board Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement to existing features jan-mar qtr Possible FY Q4 candidate
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Ruby/Thread and Ruby/Fiber spans newrelic/newrelic-ruby-agent
3 participants
@tannalynn @kford-newrelic @kaylareopelle