Retest linking of error traces to transactions and update agent implementation

[kford-newrelic]

Description

Since the completion of #2129 , there have been changes in both the agent spec as well as the server-side implementation that may prevent successfully linking error traces to transactions.

Now that the server-side implementation is available, we need to retest end-to-end that linking occurs successfully, whether Distributed Tracing is enabled or disabled.

Acceptance Criteria

Coordinate with the #help-error-tracking team on testing. Test and confirm whether our agent functions as expected. Based on that, determine what - if any - changes are needed.

Review the agent spec. Determine whether our agent is in compliance with the required aspects of the spec and based on that, determine what - if any - changes are required.

Design Consideration/Limitations

Need to ensure that linking occurs whether Distributed Tracing is enabled or not.

Dependencies

N/A

Additional context

N/A

Estimates

Please provide initial t-shirt size. S = 1-3 days, M = 3-5 days (1 week), L = 1-2 weeks (1 sprint)

[workato-integration]

https://new-relic.atlassian.net/browse/NR-251133

[kmudduluru]

we need to verify that guid is available in both TransactionError Event and ErrorTrace json events regardles of DT setting (on/off) .

[fallwith]

kmudduluru is there some place where these changes are being discussed internally so I can catch up? All of my existing Slack threads and emails on the subject went dark.

Your message here lists "TransactionError Event and ErrorTrace json events", but the internal document "Agent Ask - Always link Transactions to Traces" also mentions SQLTrace events. Can you please confirm if SQLTrace is included or not?

[kford-newrelic]

@fallwith let's capture the end-to-end test results here

[kmudduluru]

@fallwith For now the scope is only for ErrorTrace and TransactionError events. Updated the Agent Ask doc as well.

[fallwith]

NOTE: The original work was requested with #2036 and satisfied with #2035 and then later enhanced with #2137.

[fallwith]

With #2521, the transaction guid will now be added to both ErrorTrace and TransactionError types instead of just the latter. We have audited all pathways through the code and confirmed all desired behavior with DT on and off.