Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: Create injection script #2574

Closed
kford-newrelic opened this issue Apr 17, 2024 · 3 comments
Closed

k8s: Create injection script #2574

kford-newrelic opened this issue Apr 17, 2024 · 3 comments
Assignees
Labels
8 Story Point Estimate

Comments

@kford-newrelic
Copy link

kford-newrelic commented Apr 17, 2024

Description

Create a script written in Go that is responsible for injecting agent code into the customer's application container(s).

The newrelic-agent-operator repository is an OTel fork which already includes the Go scripts for a few languages, but not Ruby. Here are the other langauages scripts.

The Ruby agent code is injected into the customer’s application via a RUBYOPT environment variable that points to a setup script. This setup script uses the bundle add utility, which updates the dependency manifest and re-installs the dependencies.

Additionally, logic may need to be added to the injection script to not install the agent if an agent is already installed in the customer’s application container(s). For most agents this will likely be done by looking for the presents of certain environment variables within the customer’s application container. For example, a new relic license key. (This is very TBD at the moment-we will likely have a dedicated discussion about this and how we can/want to detect this.) The goal here is simply to not automatically install an agent into a container in which an application already has an agent installed.

Let's also consider contributing our Ruby script back to OTel.

@workato-integration
Copy link

workato-integration bot commented Apr 17, 2024

@kford-newrelic kford-newrelic added the estimate Issue needing estimation label Apr 17, 2024
@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Ruby Engineering Board Apr 17, 2024
@hannahramadan hannahramadan changed the title Review init container and GO script that injects the agent Create GO injection script May 1, 2024
@hannahramadan hannahramadan changed the title Create GO injection script k8s: Create GO injection script May 1, 2024
@hannahramadan hannahramadan changed the title k8s: Create GO injection script k8s: Create injection script May 6, 2024
@hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan moved this from In Quarter to In Sprint in Ruby Engineering Board May 20, 2024
@kford-newrelic kford-newrelic added 8 Story Point Estimate and removed estimate Issue needing estimation labels May 20, 2024
@hannahramadan
Copy link
Contributor

Closed with #2635

@github-project-automation github-project-automation bot moved this from In Sprint to Code Complete/Done in Ruby Engineering Board May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 Story Point Estimate
Projects
Archived in project
Development

No branches or pull requests

3 participants