Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NcSelect] Single select looks like tag select #4816

Closed
ChristophWurst opened this issue Nov 14, 2023 · 6 comments · Fixed by #4817
Closed

[NcSelect] Single select looks like tag select #4816

ChristophWurst opened this issue Nov 14, 2023 · 6 comments · Fixed by #4817
Assignees
@szaimen
Labels
2. developing Work in progress bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components regression Regression of a previous working feature
Milestone
8.1.0

Comments

@ChristophWurst
Copy link
Contributor

ChristophWurst commented Nov 14, 2023 •
edited
Loading

multiple=false selects should not looks like tagging selects, but they do:

image

image

this is a regression according to @marcoambrosini

it's seen across the hub with all apps ready for server 28
@ChristophWurst ChristophWurst added bug Something isn't working 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature design Design, UX, interface and interaction design feature: select Related to the NcSelect* components labels Nov 14, 2023
@ChristophWurst
Copy link
Contributor Author

As far as I can tell it's probably introduced with #4718

@szaimen
Copy link
Contributor

szaimen commented Nov 14, 2023

Yes so it looks like this was intended?

@szaimen
Copy link
Contributor

szaimen commented Nov 14, 2023

So what should it look like? Should we simply move back to the previous design?
It looked like this:
image
cc @nextcloud-libraries/designers

@ChristophWurst
Copy link
Contributor Author

Try with multiselect=false

@ChristophWurst
Copy link
Contributor Author

e.g.

25 28
Bildschirmfoto vom 2023-11-14 14-37-43 Bildschirmfoto vom 2023-11-14 14-37-58

@szaimen
Copy link
Contributor

szaimen commented Nov 14, 2023

Ah this is what you mean. Now I get it.

@szaimen szaimen mentioned this issue Nov 14, 2023
Merged
@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 14, 2023
@AndyScherzinger AndyScherzinger modified the milestones: 8.0.2, 8.1.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szaimen szaimen

Labels
2. developing Work in progress bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components regression Regression of a previous working feature
Projects
None yet
Milestone
8.1.0
Development

Successfully merging a pull request may close this issue.

fix single-select design nextcloud-libraries/nextcloud-vue
3 participants
@AndyScherzinger @ChristophWurst @szaimen