Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Adjust warning in NcPopoverTriggerProvider #5108

Closed
raimund-schluessler opened this issue Jan 22, 2024 · 0 comments · Fixed by #5110
Closed

[next] Adjust warning in NcPopoverTriggerProvider #5108

raimund-schluessler opened this issue Jan 22, 2024 · 0 comments · Fixed by #5110
Assignees
Labels
1. to develop Accepted and waiting to be taken care of feature: popover Related to the popovermenu component vue 3 Related to the vue 3 migration

Comments

@raimund-schluessler
Copy link
Contributor

These lines need to be adjusted for vue 3:

// TODO: Adjust for vue 3. Since vue 3 components can have multiple root elements, this breaks.
/**
const rootElement = this.$el
console.debug(this.$el)
const innerElement = this.$el.querySelector('[aria-expanded][aria-haspopup]')
if (!rootElement.getAttribute('aria-expanded') && !innerElement) {
warn('It looks like you are using a custom button as a <NcPopover> or other popover #trigger. If you are not using <NcButton> as a trigger, you need to bind attrs from the #trigger slot props to your custom button. See <NcPopover> docs for an example.')
}
*/

See also the discussion here
#5097 (comment)

@raimund-schluessler raimund-schluessler added 1. to develop Accepted and waiting to be taken care of feature: popover Related to the popovermenu component vue 3 Related to the vue 3 migration labels Jan 22, 2024
@raimund-schluessler raimund-schluessler self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: popover Related to the popovermenu component vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant