Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcActionButton): RTL support #6200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

falghamdi125
Copy link

@falghamdi125 falghamdi125 commented Nov 8, 2024

Hello
This PR fixes padding in RTL mode for NcActionButton.

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
01 image
004 005

@falghamdi125 falghamdi125 force-pushed the fix-ncaction-button-padding-in-rtl branch 2 times, most recently from ca9deaa to 6d4b55a Compare November 8, 2024 23:37
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Nov 11, 2024
@ShGKme ShGKme added this to the 8.20.0 milestone Nov 11, 2024
@ShGKme ShGKme changed the title Fix(NcActionButton): Add RTL support to NcActionButton component fix(NcActionButton): RTL support Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.62%. Comparing base (42efef1) to head (f0ac2e8).
Report is 53 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6200      +/-   ##
==========================================
- Coverage   42.74%   42.62%   -0.12%     
==========================================
  Files         153      154       +1     
  Lines        4029     4040      +11     
  Branches     1015     1040      +25     
==========================================
  Hits         1722     1722              
- Misses       2195     2202       +7     
- Partials      112      116       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/assets/action.scss Outdated Show resolved Hide resolved
@ShGKme ShGKme requested review from susnux and hamza221 November 11, 2024 12:18
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about what's mentioned above regarding the icon,
everything else looks good ✅

@Antreesy Antreesy modified the milestones: 8.20.0, 8.20.1 Nov 11, 2024
@falghamdi125 falghamdi125 force-pushed the fix-ncaction-button-padding-in-rtl branch from 6d4b55a to 1984091 Compare November 12, 2024 12:08
@falghamdi125 falghamdi125 force-pushed the fix-ncaction-button-padding-in-rtl branch from 1984091 to d9a0e94 Compare November 14, 2024 13:08
@susnux susnux force-pushed the fix-ncaction-button-padding-in-rtl branch from 12f3430 to f0ac2e8 Compare November 19, 2024 12:17
@falghamdi125
Copy link
Author

falghamdi125 commented Dec 6, 2024

Hi,

I believe we need to add the left arrow in RTL mode using the isRTL function. I implemented this, and it successfully updates the icon based on the direction status.

NcActionButton.vue
image

@ShGKme @hamza221 @susnux

@falghamdi125 falghamdi125 requested a review from ShGKme December 7, 2024 03:23
@ShGKme
Copy link
Contributor

ShGKme commented Dec 8, 2024

I believe we need to add the left arrow in RTL mode using the isRTL function. I implemented this, and it successfully updates the icon based on the direction status.

I agree, this is a good solution for the menu button.

@falghamdi125
Copy link
Author

Arrow direction change for RTL/LTR has been added to the PR! @ShGKme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NcActionButton incorrect padding in RTL mode
5 participants