-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcActionButton): RTL support #6200
base: master
Are you sure you want to change the base?
fix(NcActionButton): RTL support #6200
Conversation
ca9deaa
to
6d4b55a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6200 +/- ##
==========================================
- Coverage 42.74% 42.62% -0.12%
==========================================
Files 153 154 +1
Lines 4029 4040 +11
Branches 1015 1040 +25
==========================================
Hits 1722 1722
- Misses 2195 2202 +7
- Partials 112 116 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree about what's mentioned above regarding the icon,
everything else looks good ✅
6d4b55a
to
1984091
Compare
1984091
to
d9a0e94
Compare
Signed-off-by: Faisal Alghamdi <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
12f3430
to
f0ac2e8
Compare
I agree, this is a good solution for the menu button. |
Signed-off-by: Faisal Alghamdi <[email protected]>
Arrow direction change for RTL/LTR has been added to the PR! @ShGKme |
Hello
This PR fixes padding in RTL mode for NcActionButton.
☑️ Resolves
🖼️ Screenshots