Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcModal): make 'Close' button the last element for the focus-trap #6296

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

[next] fix(NcModal): make 'Close' button the last element for the focus-trap #6296

wants to merge 1 commit into from
+4 −4

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 6, 2024

Backport of PR #6266

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: modal Related to the modal component labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 2 approving reviews are required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: modal Related to the modal component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Antreesy