Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jackrabbit to the latest 2.14 release #48

Open
AndyScherzinger opened this issue Mar 5, 2017 · 12 comments
Open

Bump Jackrabbit to the latest 2.14 release #48

AndyScherzinger opened this issue Mar 5, 2017 · 12 comments

Comments

@AndyScherzinger
Copy link
Member

At the moment we are using 2.12.x which is still using http client 3.1 while the new release 2.14 bumped the version to 4.1, see http://jackrabbit.510166.n4.nabble.com/ANNOUNCE-Apache-Jackrabbit-2-14-0-released-td4666058.html

The main changes in this release are:

  • Switch WebDAV client components to HttpClient 4.5.x (summary in JCR-2406)
  • Introduction of Commons-VFS Datastore implementation (JCR-3975)
  • Allow use of JDK7 features (JCR-4030)

cc @mario @tobiasKaminsky

@mario
Copy link
Contributor

mario commented Mar 5, 2017

I completely support you in working on this! :)

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Mar 5, 2017

Warning:WARNING: Dependency org.apache.httpcomponents:httpclient:4.5.2 is ignored for debug as it may be conflicting with the internal version provided by Android.
Warning:WARNING: Dependency org.apache.httpcomponents:httpclient:4.5.2 is ignored for release as it may be conflicting with the internal version provided by Android.

This might be an issue though since older versions of Android ship the http client themselves which it might need to be repacked, but then that hasn't been done before (ever)

@mario
Copy link
Contributor

mario commented Mar 5, 2017

Fork, change name of the lib, include :D

@AndyScherzinger
Copy link
Member Author

Name is not enough
you need to change the packages, else you will have collisions and depend on the classloader to pick the one you want!

@mario
Copy link
Contributor

mario commented Mar 5, 2017

I know. I was joking :P Do it :D

@AndyScherzinger
Copy link
Member Author

alternatively we could look at https://github.com/lookfirst/sardine but that might need a bit of work to integrate too since it might (also) not be Android compatible

@mario
Copy link
Contributor

mario commented Mar 5, 2017

Already looked into that - not Android compatible, and the Android-compatible fork is really really bad.

Long term, I think we'll either write our own lib or extend the one used by DavDroid to suit us, but for now ... I really think we should integrate 2.14 if we can in any way.

@AndyScherzinger
Copy link
Member Author

Not sure if that works, since we would have to do what's been mentioned above, repackaging the complete thing... Since the build will drop the http client (which is incompatible to 3.x) and this is likely breaking the whole thing :/

@AndyScherzinger
Copy link
Member Author

installed https://github.com/nextcloud/android/tree/jackrabbit214 on my phone and it seems to work... will have to test this a little.

Anyone having a IPv6 Installation?

@rubdos
Copy link

rubdos commented Mar 13, 2017

Anyone having a IPv6 Installation?

Yes, is it the right time to test this now?

@AndyScherzinger
Copy link
Member Author

Yes, is it the right time to test this now?

No, I just asked since I don't have an IPv6 setup, so I can't really work on this issue even if I wanted to...

@tobiasKaminsky
Copy link
Member

This is being worked on right now: I switched get activity operation already to newest v2 system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants