Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating an external app must not automatically enable it #474

Closed
nickvergessen opened this issue Dec 20, 2024 · 0 comments · Fixed by #478
Closed

Updating an external app must not automatically enable it #474

nickvergessen opened this issue Dec 20, 2024 · 0 comments · Fixed by #478
Labels
bug Something isn't working

Comments

@nickvergessen
Copy link
Member

PHP apps

  • Have a list of enabled and disabled apps
  • Run occ app:update --all
  • List of enabled and disabled apps is the same, apart from the version

AppAPI apps

  • Have a list of enabled and disabled apps
  • Run occ app_api:app:update --all
  • All apps that were updated are now also enabled 💥

The difference is unexpected.
AppAPI apps that were disabled before should stay disabled
@nickvergessen nickvergessen added the bug Something isn't working label Dec 20, 2024
@andrey18106 andrey18106 mentioned this issue Dec 26, 2024
Merged
andrey18106 added a commit that referenced this issue Dec 27, 2024
@andrey18106
fix(occ): correct app_api:app:update enabled state of ExApps, intro…
217a6f9 
…duce helper options (#478)

Resolves: #474 

This PR corrects AppAPI `occ app_api:app:update` command logic in the
following way:

1. By default disabled ExApps are not updated. Use option
`--include-disabled` to update disabled ExApps too.
2. During update ExApp is enabled to perform initialization step, if it
was disabled before update - by default it will be disabled after
update.

---------

Signed-off-by: Andrey Borysenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@nickvergessen