Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp in filename issue #2657

Closed
come-nc opened this issue Dec 5, 2023 · 2 comments
Closed

Timestamp in filename issue #2657

come-nc opened this issue Dec 5, 2023 · 2 comments
Assignees
Labels
0. Needs triage Issues that need to be triaged bug feature: trashbin Items related to the trashbin feature

Comments

@come-nc
Copy link
Contributor

come-nc commented Dec 5, 2023

I am not completely sure how this affects features, but there is an inconsistency between file URL in UI and database.

The issue is that files_trashbin/Sabre/TrashFile uses getLastModified to build the filename, while in other places we use deleted_time.

I think for legacy backend mtime and deletedtime are the same thing because in apps/files_trashbin/lib/Helper.php:88 the timestamp from filename is put in mtime.

We can either change groupfolders trashbin backend to fake mtime to deleted_time or change files_trashbin to consistently use getDeletedTime instead of getLastModified or getMTime.

@come-nc
Copy link
Contributor Author

come-nc commented Feb 20, 2024

@icewind1991 I think we can close this one?

@joshtrichards joshtrichards added the feature: trashbin Items related to the trashbin feature label Jul 26, 2024
@joshtrichards
Copy link
Member

#2714 (comment)
Fixed in nextcloud/server#42558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged bug feature: trashbin Items related to the trashbin feature
Projects
None yet
Development

No branches or pull requests

2 participants