Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reflow text for feeds that provide plaintext content #1270

Closed
zachpmanson opened this issue Sep 21, 2023 · 2 comments · Fixed by #1272
Closed

Add option to reflow text for feeds that provide plaintext content #1270

zachpmanson opened this issue Sep 21, 2023 · 2 comments · Fixed by #1272

Comments

@zachpmanson
Copy link

Some feeds provide plaintext as the body of their feed items and insert newlines every 70 characters or so. This looks great on a terminal but quite bad on most phones in vertical orientations:

Screenshot_20230922-091826.png

My suggestion is adding an option to the overflow menu for these feeds that would collapse single newlines into spaces and double newlines into single newlines. It would be a toggle per post or per feed.

@stefan-niedermann
Copy link
Member

Wouldn't it make more sense to "fix" (aka "special handle") this case in the News server app?

Given they also have a responsive UI, they probably suffer the same issue?

@mkanilsson
Copy link
Contributor

mkanilsson commented Sep 22, 2023

@stefan-niedermann

This doesn't happen in the server app.

This is how it looks on my nextcloud instance:
(full width)
nextcloud_formating

(small width)
portrait_nextcloud

and this is how it looks in the app:

Notice that it breaks at "as" in the app but not in the web version

I've created a PR that fixes this: #1272 but it isn't an option as there are no visual changes except the formatting getting fixed which I guess everyone wants at all time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants