Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): Add index on device identifier for quicker deletion #1806

Merged
merged 1 commit into from
Feb 22, 2024
Merged

feat(db): Add index on device identifier for quicker deletion #1806

merged 1 commit into from
Feb 22, 2024

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Jan 31, 2024
@nickvergessen nickvergessen self-assigned this Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 10984 was 10000 (+9.84%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

juliusknorr
juliusknorr approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't seem to be the origin of the issue I've seen but still makes sense I'd say 👍

@nickvergessen nickvergessen merged commit a41fc4f into master Feb 22, 2024
36 checks passed
@nickvergessen nickvergessen deleted the feat/noid/add-missing-indices branch February 22, 2024 12:44
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: push 📲 performance
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @juliusknorr